d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

devtools: ignore internal ABI check

Browse Source 
Ignore the internal version ABI check, this kind of ABI is used only
by drivers and libraries.

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
This commit is contained in:
Haiyue Wang 2020-04-25 18:56:18 +08:00 committed by David Marchand
parent 4c82473412
commit 2c32cfdee1
2 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
devtools/check-symbol-change.sh
View File

@ -77,6 +77,10 @@ build_map_changes()
} }
is_stable_section() {
[ "$1" != 'EXPERIMENTAL' ] && [ "$1" != 'INTERNAL' ]
}
check_for_rule_violations() check_for_rule_violations()
{ {
local mapdb="$1" local mapdb="$1"
@ -106,15 +110,14 @@ check_for_rule_violations()
oldsecname=$(sed -n \ oldsecname=$(sed -n \
"s#$mname $symname \(.*\) del#\1#p" "$mapdb") "s#$mname $symname \(.*\) del#\1#p" "$mapdb")
# A symbol can not enter a non experimental # A symbol can not enter a stable section directly
# section directly
if [ -z "$oldsecname" ] if [ -z "$oldsecname" ]
then then
if [ "$secname" = 'EXPERIMENTAL' ] if ! is_stable_section $secname
then then
echo -n "INFO: symbol $symname has " echo -n "INFO: symbol $symname has "
echo -n "been added to the " echo -n "been added to the "
echo -n "EXPERIMENTAL section of the " echo -n "$secname section of the "
echo "version map" echo "version map"
continue continue
else else
@ -135,9 +138,9 @@ check_for_rule_violations()
fi fi
# This symbol is moving between two sections (the # This symbol is moving between two sections (the
# original section is not experimental). # original section is a stable section).
# This can be legit, just warn. # This can be legit, just warn.
if [ "$oldsecname" != 'EXPERIMENTAL' ] if is_stable_section $oldsecname
then then
echo -n "INFO: symbol $symname is being " echo -n "INFO: symbol $symname is being "
echo -n "moved from $oldsecname to $secname. " echo -n "moved from $oldsecname to $secname. "
@ -148,9 +151,9 @@ check_for_rule_violations()
else else
if ! grep -q "$mname $symname .* add" "$mapdb" && \ if ! grep -q "$mname $symname .* add" "$mapdb" && \
[ "$secname" != "EXPERIMENTAL" ] is_stable_section $secname
then then
# Just inform users that non-experimenal # Just inform users that stable
# symbols need to go through a deprecation # symbols need to go through a deprecation
# process # process
echo -n "INFO: symbol $symname is being " echo -n "INFO: symbol $symname is being "

5
devtools/libabigail.abignore
View File

@ -3,6 +3,11 @@
[suppress_variable] [suppress_variable]
symbol_version = EXPERIMENTAL symbol_version = EXPERIMENTAL
[suppress_function]
symbol_version = INTERNAL
[suppress_variable]
symbol_version = INTERNAL
; Explicit ignore for driver-only ABI ; Explicit ignore for driver-only ABI
[suppress_type] [suppress_type]
name = rte_cryptodev_ops name = rte_cryptodev_ops