d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/vdev_netvsc: readlink inputs cannot be aliased

Browse Source 
drivers/net/vdev_netvsc/vdev_netvsc.c:335:2:error:
passing argument 2 to restrict-qualified parameter aliases with argument 1
  ret = readlink(buf, buf, size);
  ^~~

Fixes: e7dc5d7becc5 ("net/vdev_netvsc: implement core functionality")
Cc: stable@dpdk.org

Signed-off-by: Andy Green <andy@warmcat.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
This commit is contained in:
Andy Green 2018-05-14 13:00:52 +08:00 committed by Ferruh Yigit
parent ed5b98483a
commit 2e4d2e563f
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/vdev_netvsc/vdev_netvsc.c
View File

@ -327,12 +327,15 @@ static int
vdev_netvsc_sysfs_readlink(char *buf, size_t size, const char *if_name, vdev_netvsc_sysfs_readlink(char *buf, size_t size, const char *if_name,
const char *relpath) const char *relpath)
{ {
struct vdev_netvsc_ctx *ctx;
char in[RTE_MAX(sizeof(ctx->yield), 256u)];
int ret; int ret;
ret = snprintf(buf, size, "/sys/class/net/%s/%s", if_name, relpath); ret = snprintf(in, sizeof(in) - 1, "/sys/class/net/%s/%s",
if (ret == -1 || (size_t)ret >= size) if_name, relpath);
if (ret == -1 || (size_t)ret >= sizeof(in))
return -ENOBUFS; return -ENOBUFS;
ret = readlink(buf, buf, size); ret = readlink(in, buf, size);
if (ret == -1) if (ret == -1)
return -errno; return -errno;
if ((size_t)ret >= size - 1) if ((size_t)ret >= size - 1)