d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

compressdev: fix op allocation

Browse Source 
Fixed bad logic in rte_comp_op_alloc() checking return
value from rte_comp_op_raw_bulk_alloc(). This
could have resulted in a seg-fault in error case.
Made rte_comp_ob_bulk_alloc() code consistent
with rte_comp_op_alloc().

Fixes: 96086db5a369 ("compressdev: add operation management")
Cc: stable@dpdk.org

Reported-by: Sabyasachi Sengupta <sabyasg@hpe.com>
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Shally Verma <shally.verma@caviumnetworks.com>
This commit is contained in:
Fiona Trahe 2018-10-27 01:43:07 +01:00 committed by Akhil Goyal
parent 1fca14d7dd
commit 30fadd8bc9
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/librte_compressdev/rte_comp.c
View File

@ -174,7 +174,7 @@ rte_comp_op_alloc(struct rte_mempool *mempool)
int retval;
retval = rte_comp_op_raw_bulk_alloc(mempool, &op, 1);
if (unlikely(retval < 0))
if (unlikely(retval != 1))
return NULL;
rte_comp_op_reset(op);
@ -186,12 +186,12 @@ int __rte_experimental
rte_comp_op_bulk_alloc(struct rte_mempool *mempool,
struct rte_comp_op **ops, uint16_t nb_ops)
{
int ret;
int retval;
uint16_t i;
ret = rte_comp_op_raw_bulk_alloc(mempool, ops, nb_ops);
if (unlikely(ret < nb_ops))
return ret;
retval = rte_comp_op_raw_bulk_alloc(mempool, ops, nb_ops);
if (unlikely(retval != nb_ops))
return 0;
for (i = 0; i < nb_ops; i++)
rte_comp_op_reset(ops[i]);