d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/test: fix sprintf with strlcat

Browse Source 
sprintf function is not secure as it doesn't check the length of string.
More secure function strlcat is used.

Fixes: 727909c592 ("app/test: introduce dynamic commands list")
Cc: stable@dpdk.org

Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
Reviewed-by: Aaron Conole <aconole@redhat.com>
This commit is contained in:
Pallantla Poornima 2019-03-13 11:07:23 +00:00 committed by Thomas Monjalon
parent c12cefa379
commit 323643727f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/test/commands.c
View File

@ -44,6 +44,7 @@
#include <cmdline_parse_num.h> #include <cmdline_parse_num.h>
#include <cmdline_parse_string.h> #include <cmdline_parse_string.h>
#include <cmdline.h> #include <cmdline.h>
#include <rte_string_fns.h>
#include "test.h" #include "test.h"
@ -365,23 +366,22 @@ cmdline_parse_ctx_t main_ctx[] = {
int commands_init(void) int commands_init(void)
{ {
struct test_command *t; struct test_command *t;
char *commands, *ptr; char *commands;
int commands_len = 0; int commands_len = 0;
TAILQ_FOREACH(t, &commands_list, next) { TAILQ_FOREACH(t, &commands_list, next) {
commands_len += strlen(t->command) + 1; commands_len += strlen(t->command) + 1;
} }
commands = malloc(commands_len + 1); commands = (char *)calloc(commands_len, sizeof(char));
if (!commands) if (!commands)
return -1; return -1;
ptr = commands;
TAILQ_FOREACH(t, &commands_list, next) { TAILQ_FOREACH(t, &commands_list, next) {
ptr += sprintf(ptr, "%s#", t->command); strlcat(commands, t->command, commands_len);
if (TAILQ_NEXT(t, next) != NULL)
strlcat(commands, "#", commands_len);
} }
ptr--;
ptr[0] = '\0';
cmd_autotest_autotest.string_data.str = commands; cmd_autotest_autotest.string_data.str = commands;
return 0; return 0;