d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/ice: check some functions return

Browse Source 
Fix unchecked return values reported by coverity.

Coverity issue: 349907
Fixes: 03a05924da ("net/ice: support device-specific DDP package loading")
Cc: stable@dpdk.org

Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
This commit is contained in:
Wenjun Wu 2021-02-26 15:22:00 +08:00 committed by Qi Zhang
parent df7547a6a2
commit 32667f5b48
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/net/ice/ice_ethdev.c
View File

@ -1663,8 +1663,14 @@ ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file)
pos = rte_pci_find_ext_capability(pci_dev, RTE_PCI_EXT_CAP_ID_DSN);
if (pos) {
rte_pci_read_config(pci_dev, &dsn_low, 4, pos + 4);
rte_pci_read_config(pci_dev, &dsn_high, 4, pos + 8);
if (rte_pci_read_config(pci_dev, &dsn_low, 4, pos + 4) < 0) {
PMD_INIT_LOG(ERR, "Failed to read pci config space\n");
return -1;
}
if (rte_pci_read_config(pci_dev, &dsn_high, 4, pos + 8) < 0) {
PMD_INIT_LOG(ERR, "Failed to read pci config space\n");
return -1;
}
snprintf(opt_ddp_filename, ICE_MAX_PKG_FILENAME_SIZE,
"ice-%08x%08x.pkg", dsn_high, dsn_low);
} else {
@ -1727,7 +1733,11 @@ static int ice_load_pkg(struct rte_eth_dev *dev)
struct ice_adapter *ad =
ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
ice_pkg_file_search_path(pci_dev, pkg_file);
err = ice_pkg_file_search_path(pci_dev, pkg_file);
if (err) {
PMD_INIT_LOG(ERR, "failed to search file path\n");
return err;
}
file = fopen(pkg_file, "rb");
if (!file) {