d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eal: check peer allocation in multi-process request

Browse Source 
Add the check for null peer pointer like the bundle pointer in the mp request
handler. They should follow same style. And add some logs for nomem cases.

Signed-off-by: Gao Feng <davidfgao@tencent.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
This commit is contained in:
Gao Feng 2018-12-05 14:19:24 +08:00 committed by Thomas Monjalon
parent e14bc93e8f
commit 32fa7f8913
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/librte_eal/common/hotplug_mp.c
View File

@ -200,6 +200,11 @@ handle_secondary_request(const struct rte_mp_msg *msg, const void *peer)
* when it is ready.
*/
bundle->peer = strdup(peer);
if (bundle->peer == NULL) {
free(bundle);
RTE_LOG(ERR, EAL, "not enough memory\n");
return send_response_to_secondary(req, -ENOMEM, peer);
}
/**
* We are at IPC callback thread, sync IPC is not allowed due to
@ -313,6 +318,7 @@ handle_primary_request(const struct rte_mp_msg *msg, const void *peer)
bundle = calloc(1, sizeof(*bundle));
if (bundle == NULL) {
RTE_LOG(ERR, EAL, "not enough memory\n");
resp->result = -ENOMEM;
ret = rte_mp_reply(&mp_resp, peer);
if (ret)
@ -327,6 +333,15 @@ handle_primary_request(const struct rte_mp_msg *msg, const void *peer)
* when it is ready.
*/
bundle->peer = (void *)strdup(peer);
if (bundle->peer == NULL) {
RTE_LOG(ERR, EAL, "not enough memory\n");
free(bundle);
resp->result = -ENOMEM;
ret = rte_mp_reply(&mp_resp, peer);
if (ret)
RTE_LOG(ERR, EAL, "failed to send reply to primary request\n");
return ret;
}
/**
* We are at IPC callback thread, sync IPC is not allowed due to