d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/bnxt: fix RSS table update for start/stop Rx queue

Browse Source 
A previous commit made updating of the RSS table when a receive
queue is stopped/started conditional on vnic->rx_queue_cnt being
nonzero. This count is only nonzero for dynamically created VNICs,
so the RSS table was not being updated in the normal path.
Fix by restoring the original logic.

Also ensure that vnic->rx_queue_cnt is initialized to zero when
reinitializing the VNIC array.

Fixes: 36024b2e7f ("net/bnxt: allow dynamic creation of VNIC")

Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
This commit is contained in:
Lance Richardson 2019-11-04 15:27:44 -05:00 committed by Ferruh Yigit
parent 21b1f1abe4
commit 34a068411a
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/bnxt/bnxt_rxq.c
View File

@ -466,8 +466,7 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
}
PMD_DRV_LOG(DEBUG, "Rx Queue Count %d\n", vnic->rx_queue_cnt);
if (vnic->rx_queue_cnt > 1)
rc = bnxt_vnic_rss_configure(bp, vnic);
rc = bnxt_vnic_rss_configure(bp, vnic);
}
if (rc == 0)
@ -522,8 +521,7 @@ int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
vnic->fw_grp_ids[rx_queue_id] = INVALID_HW_RING_ID;
PMD_DRV_LOG(DEBUG, "Rx Queue Count %d\n", vnic->rx_queue_cnt);
if (vnic->rx_queue_cnt > 1)
rc = bnxt_vnic_rss_configure(bp, vnic);
rc = bnxt_vnic_rss_configure(bp, vnic);
}
if (rc == 0)

1
drivers/net/bnxt/bnxt_vnic.c
View File

@ -51,6 +51,7 @@ static void bnxt_init_vnics(struct bnxt *bp)
vnic->lb_rule = (uint16_t)HWRM_NA_SIGNATURE;
vnic->hash_mode =
HWRM_VNIC_RSS_CFG_INPUT_HASH_MODE_FLAGS_DEFAULT;
vnic->rx_queue_cnt = 0;
STAILQ_INIT(&vnic->filter);
STAILQ_INIT(&vnic->flow_list);