d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/pdump: fix vdev cleanup

Browse Source 
Virtual devices added in pdump application
using rte_eal_hotplug_add should be removed explicitly
while exiting the pdump application, otherwise the
subsequent run of the pdump application will fail with the reason
that virtual devices with the same name already exists in primary.

Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev attach")
Cc: stable@dpdk.org

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
This commit is contained in:
Reshma Pattan 2019-01-15 13:45:04 +00:00 committed by Thomas Monjalon
parent 7c06d9258a
commit 35cb223ab7
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/pdump/main.c
View File

@ -494,6 +494,7 @@ cleanup_pdump_resources(void)
{ {
int i; int i;
struct pdump_tuples *pt; struct pdump_tuples *pt;
char name[RTE_ETH_NAME_MAX_LEN];
/* disable pdump and free the pdump_tuple resources */ /* disable pdump and free the pdump_tuple resources */
for (i = 0; i < num_tuples; i++) { for (i = 0; i < num_tuples; i++) {
@ -510,6 +511,14 @@ cleanup_pdump_resources(void)
free_ring_data(pt->rx_ring, pt->rx_vdev_id, &pt->stats); free_ring_data(pt->rx_ring, pt->rx_vdev_id, &pt->stats);
if (pt->dir & RTE_PDUMP_FLAG_TX) if (pt->dir & RTE_PDUMP_FLAG_TX)
free_ring_data(pt->tx_ring, pt->tx_vdev_id, &pt->stats); free_ring_data(pt->tx_ring, pt->tx_vdev_id, &pt->stats);
/* Remove the vdev created */
rte_eth_dev_get_name_by_port(pt->rx_vdev_id, name);
rte_eal_hotplug_remove("vdev", name);
rte_eth_dev_get_name_by_port(pt->tx_vdev_id, name);
rte_eal_hotplug_remove("vdev", name);
} }
cleanup_rings(); cleanup_rings();
} }