virtio: fix query of legacy features
Declare dst as type uint32_t instead of uint64_t, otherwise, we will get
a random upper 32 bit feature bits, as the following io port read reads
lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1
(the 32th bit) for legacy virtio, which is obviously wrong.
Fixes: b8f04520ad
("virtio: use PCI ioport API")
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
Reviewed-by: David Marchand <david.marchand@6wind.com>
This commit is contained in:
parent
6b5a857fb0
commit
36ea36efb4
@ -74,7 +74,7 @@ legacy_write_dev_config(struct virtio_hw *hw, size_t offset,
|
||||
static uint64_t
|
||||
legacy_get_features(struct virtio_hw *hw)
|
||||
{
|
||||
uint64_t dst;
|
||||
uint32_t dst;
|
||||
|
||||
rte_eal_pci_ioport_read(&hw->io, &dst, 4, VIRTIO_PCI_HOST_FEATURES);
|
||||
return dst;
|
||||
|
Loading…
Reference in New Issue
Block a user