d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/sfc: use more robust string comparison

Browse Source 
When it comes to comparing HW switch ID strings,
use strncmp to avoid reading past the buffer.

Fixes: e86b48aa46d4 ("net/sfc: add HW switch ID helpers")

Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
This commit is contained in:
Ivan Malov 2020-11-09 14:46:06 +03:00 committed by Ferruh Yigit
parent df78fe717e
commit 380f355228
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/sfc/sfc.c
View File

@ -1301,5 +1301,6 @@ bool
sfc_hw_switch_ids_equal(const struct sfc_hw_switch_id *left,
const struct sfc_hw_switch_id *right)
{
return strcmp(left->board_sn, right->board_sn) == 0;
return strncmp(left->board_sn, right->board_sn,
sizeof(left->board_sn)) == 0;
}