d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eal: remove dependency on vdev in attach

Browse Source 
We can call bus->plug() to avoid calling rte_vdev_init() explicitly.

Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
This commit is contained in:
Jianfeng Tan 2017-11-07 06:54:20 +00:00 committed by Thomas Monjalon
parent 49c80d31fe
commit 394d5b4c0a
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/librte_eal/common/eal_common_dev.c
View File

@ -67,7 +67,6 @@ static int cmp_dev_name(const struct rte_device *dev, const void *_name)
int rte_eal_dev_attach(const char *name, const char *devargs)
{
struct rte_bus *bus;
int ret;
if (name == NULL || devargs == NULL) {
RTE_LOG(ERR, EAL, "Invalid device or arguments provided\n");
@ -80,22 +79,13 @@ int rte_eal_dev_attach(const char *name, const char *devargs)
name);
return -EINVAL;
}
if (strcmp(bus->name, "pci") == 0)
return rte_eal_hotplug_add("pci", name, devargs);
if (strcmp(bus->name, "vdev") != 0) {
RTE_LOG(ERR, EAL, "Device attach is only supported for PCI and vdev devices.\n");
return -ENOTSUP;
}
if (strcmp(bus->name, "pci") == 0 || strcmp(bus->name, "vdev") == 0)
return rte_eal_hotplug_add(bus->name, name, devargs);
/*
* If we haven't found a bus device the user meant to "hotplug" a
* virtual device instead.
*/
ret = rte_vdev_init(name, devargs);
if (ret)
RTE_LOG(ERR, EAL, "Driver cannot attach the device (%s)\n",
name);
return ret;
RTE_LOG(ERR, EAL,
"Device attach is only supported for PCI and vdev devices.\n");
return -ENOTSUP;
}
int rte_eal_dev_detach(struct rte_device *dev)