d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/ice/base: replace alloc-followed-by-copy with memdup

Browse Source 
ice_memdup() is preferred over an alloc immediately followed by a copy.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Qiming Yang <qiming.yang@intel.com>
This commit is contained in:
Qi Zhang 2019-09-23 15:44:36 +08:00 committed by Ferruh Yigit
parent ddae044035
commit 3a010f01d3
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ice/base/ice_flex_pipe.c
View File

@ -4939,12 +4939,11 @@ ice_get_profs_vsig(struct ice_hw *hw, enum ice_block blk, u16 vsig,
struct ice_vsig_prof *p; struct ice_vsig_prof *p;
/* copy to the input list */ /* copy to the input list */
p = (struct ice_vsig_prof *)ice_malloc(hw, sizeof(*p)); p = (struct ice_vsig_prof *)ice_memdup(hw, ent1, sizeof(*p),
ICE_NONDMA_TO_NONDMA);
if (!p) if (!p)
goto err_ice_get_profs_vsig; goto err_ice_get_profs_vsig;
ice_memcpy(p, ent1, sizeof(*p), ICE_NONDMA_TO_NONDMA);
LIST_ADD_TAIL(&p->list, lst); LIST_ADD_TAIL(&p->list, lst);
} }

7
drivers/net/ice/base/ice_switch.c
View File

@ -623,14 +623,11 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,
recps[rid].big_recp = (num_recps > 1); recps[rid].big_recp = (num_recps > 1);
recps[rid].n_grp_count = num_recps; recps[rid].n_grp_count = num_recps;
recps[rid].root_buf = (struct ice_aqc_recipe_data_elem *) recps[rid].root_buf = (struct ice_aqc_recipe_data_elem *)
ice_calloc(hw, recps[rid].n_grp_count, ice_memdup(hw, tmp, recps[rid].n_grp_count *
sizeof(struct ice_aqc_recipe_data_elem)); sizeof(*recps[rid].root_buf), ICE_NONDMA_TO_NONDMA);
if (!recps[rid].root_buf) if (!recps[rid].root_buf)
goto err_unroll; goto err_unroll;
ice_memcpy(recps[rid].root_buf, tmp, recps[rid].n_grp_count *
sizeof(*recps[rid].root_buf), ICE_NONDMA_TO_NONDMA);
/* Copy result indexes */ /* Copy result indexes */
ice_memcpy(recps[rid].res_idxs, result_bm, sizeof(recps[rid].res_idxs), ice_memcpy(recps[rid].res_idxs, result_bm, sizeof(recps[rid].res_idxs),
ICE_NONDMA_TO_NONDMA); ICE_NONDMA_TO_NONDMA);