d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/vhost: enable compliant offloading mode

Browse Source 
This patch enables the compliant offloading flags mode by
default, which prevents the Rx path to set Tx offload flags,
which is illegal. A new legacy-ol-flags devarg is introduced
to enable the legacy behaviour.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
This commit is contained in:
Maxime Coquelin 2022-06-08 14:49:43 +02:00
parent 7316b4fd61
commit 3a6ee8dafb
2 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/guides/nics/vhost.rst
View File

@ -64,6 +64,12 @@ The user can specify below arguments in `--vdev` option.
It is used to enable external buffer support in vhost library. It is used to enable external buffer support in vhost library.
(Default: 0 (disabled)) (Default: 0 (disabled))
#. ``legacy-ol-flags``:
It is used to restore legacy behavior for offloading that was not
compliant with offloading API.
(Default: 0 (disabled))
Vhost PMD event handling Vhost PMD event handling
------------------------ ------------------------

20
drivers/net/vhost/rte_eth_vhost.c
View File

@ -31,9 +31,10 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};
#define ETH_VHOST_CLIENT_ARG "client" #define ETH_VHOST_CLIENT_ARG "client"
#define ETH_VHOST_IOMMU_SUPPORT "iommu-support" #define ETH_VHOST_IOMMU_SUPPORT "iommu-support"
#define ETH_VHOST_POSTCOPY_SUPPORT "postcopy-support" #define ETH_VHOST_POSTCOPY_SUPPORT "postcopy-support"
#define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso" #define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso"
#define ETH_VHOST_LINEAR_BUF "linear-buffer" #define ETH_VHOST_LINEAR_BUF "linear-buffer"
#define ETH_VHOST_EXT_BUF "ext-buffer" #define ETH_VHOST_EXT_BUF "ext-buffer"
#define ETH_VHOST_LEGACY_OL_FLAGS "legacy-ol-flags"
#define VHOST_MAX_PKT_BURST 32 #define VHOST_MAX_PKT_BURST 32
static const char *valid_arguments[] = { static const char *valid_arguments[] = {
@ -45,6 +46,7 @@ static const char *valid_arguments[] = {
ETH_VHOST_VIRTIO_NET_F_HOST_TSO, ETH_VHOST_VIRTIO_NET_F_HOST_TSO,
ETH_VHOST_LINEAR_BUF, ETH_VHOST_LINEAR_BUF,
ETH_VHOST_EXT_BUF, ETH_VHOST_EXT_BUF,
ETH_VHOST_LEGACY_OL_FLAGS,
NULL NULL
}; };
@ -1470,6 +1472,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
int tso = 0; int tso = 0;
int linear_buf = 0; int linear_buf = 0;
int ext_buf = 0; int ext_buf = 0;
int legacy_ol_flags = 0;
struct rte_eth_dev *eth_dev; struct rte_eth_dev *eth_dev;
const char *name = rte_vdev_device_name(dev); const char *name = rte_vdev_device_name(dev);
@ -1579,6 +1582,17 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
flags |= RTE_VHOST_USER_EXTBUF_SUPPORT; flags |= RTE_VHOST_USER_EXTBUF_SUPPORT;
} }
if (rte_kvargs_count(kvlist, ETH_VHOST_LEGACY_OL_FLAGS) == 1) {
ret = rte_kvargs_process(kvlist,
ETH_VHOST_LEGACY_OL_FLAGS,
&open_int, &legacy_ol_flags);
if (ret < 0)
goto out_free;
}
if (legacy_ol_flags == 0)
flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
if (dev->device.numa_node == SOCKET_ID_ANY) if (dev->device.numa_node == SOCKET_ID_ANY)
dev->device.numa_node = rte_socket_id(); dev->device.numa_node = rte_socket_id();