d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

buildtools: check allocation error in pmdinfogen

Browse Source 
In func locate_pmd_entries(), pointer 'new' returned from call to func
'calloc' may be NULL. It is dereferenced without null point check.

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
This commit is contained in:
Yong Wang 2017-09-15 07:33:08 -04:00 committed by Thomas Monjalon
parent f0df35313f
commit 3b29f60f2d
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
buildtools/pmdinfogen/pmdinfogen.c
View File

@ -327,6 +327,10 @@ static int locate_pmd_entries(struct elf_info *info)
do { do {
new = calloc(sizeof(struct pmd_driver), 1); new = calloc(sizeof(struct pmd_driver), 1);
if (new == NULL) {
fprintf(stderr, "Failed to calloc memory\n");
return -1;
}
new->name_sym = find_sym_in_symtab(info, "this_pmd_name", last); new->name_sym = find_sym_in_symtab(info, "this_pmd_name", last);
last = new->name_sym; last = new->name_sym;
if (!new->name_sym) if (!new->name_sym)
@ -408,7 +412,8 @@ int main(int argc, char **argv)
} }
parse_elf(&info, argv[1]); parse_elf(&info, argv[1]);
locate_pmd_entries(&info); if (locate_pmd_entries(&info) < 0)
exit(1);
if (info.drivers) { if (info.drivers) {
output_pmd_info_string(&info, argv[2]); output_pmd_info_string(&info, argv[2]);