d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pdump: fix string overflow

Browse Source 
replaced strncpy with snprintf for safely
copying the strings.

Coverity issue: 127350

Fixes: 278f945402 ("pdump: add new library for packet capture")

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
This commit is contained in:
Reshma Pattan 2016-06-24 17:36:21 +01:00 committed by Thomas Monjalon
parent f3c1829130
commit 3bb262e263
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/librte_pdump/rte_pdump.c
View File

@ -810,13 +810,15 @@ pdump_prepare_client_request(char *device, uint16_t queue,
req.flags = flags;
req.op = operation;
if ((operation & ENABLE) != 0) {
strncpy(req.data.en_v1.device, device, strlen(device));
snprintf(req.data.en_v1.device, sizeof(req.data.en_v1.device),
"%s", device);
req.data.en_v1.queue = queue;
req.data.en_v1.ring = ring;
req.data.en_v1.mp = mp;
req.data.en_v1.filter = filter;
} else {
strncpy(req.data.dis_v1.device, device, strlen(device));
snprintf(req.data.dis_v1.device, sizeof(req.data.dis_v1.device),
"%s", device);
req.data.dis_v1.queue = queue;
req.data.dis_v1.ring = NULL;
req.data.dis_v1.mp = NULL;