d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

examples/packet_ordering: enhance getopt_long usage

Browse Source 
Instead of using getopt_long return value, strcmp was used to
compare the input parameters with the struct option array. This
patch get rid of all those strcmp by directly binding each longopt
with an int enum. This is to improve readability and consistency in
all examples.

Bugzilla ID: 238

Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
This commit is contained in:
Ibtisam Tariq 2021-02-04 07:34:16 +00:00 committed by David Marchand
parent ec4887414a
commit 3bb3ebb51b
1 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
examples/packet_ordering/main.c
View File

@ -29,6 +29,13 @@
/* Macros for printing using RTE_LOG */
#define RTE_LOGTYPE_REORDERAPP RTE_LOGTYPE_USER1
enum {
#define OPT_DISABLE_REORDER "disable-reorder"
OPT_DISABLE_REORDER_NUM = 256,
#define OPT_INSIGHT_WORKER "insight-worker"
OPT_INSIGHT_WORKER_NUM,
};
unsigned int portmask;
unsigned int disable_reorder;
unsigned int insight_worker;
@ -157,9 +164,9 @@ parse_args(int argc, char **argv)
char **argvopt;
char *prgname = argv[0];
static struct option lgopts[] = {
{"disable-reorder", 0, 0, 0},
{"insight-worker", 0, 0, 0},
{NULL, 0, 0, 0}
{OPT_DISABLE_REORDER, 0, NULL, OPT_DISABLE_REORDER_NUM},
{OPT_INSIGHT_WORKER, 0, NULL, OPT_INSIGHT_WORKER_NUM },
{NULL, 0, 0, 0 }
};
argvopt = argv;
@ -176,18 +183,18 @@ parse_args(int argc, char **argv)
return -1;
}
break;
/* long options */
case 0:
if (!strcmp(lgopts[option_index].name, "disable-reorder")) {
printf("reorder disabled\n");
disable_reorder = 1;
}
if (!strcmp(lgopts[option_index].name,
"insight-worker")) {
printf("print all worker statistics\n");
insight_worker = 1;
}
case OPT_DISABLE_REORDER_NUM:
printf("reorder disabled\n");
disable_reorder = 1;
break;
case OPT_INSIGHT_WORKER_NUM:
printf("print all worker statistics\n");
insight_worker = 1;
break;
default:
print_usage(prgname);
return -1;