d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eal: simplify exit functions

Browse Source 
The option RTE_EAL_ALWAYS_PANIC_ON_ERROR was off by default,
and not customizable with meson. It is completely removed.

The function rte_dump_registers is a trace of the bare metal support
era, and was not supported in userland. It is completely removed.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: David Marchand <david.marchand@redhat.com>
This commit is contained in:
Thomas Monjalon 2020-09-28 02:00:48 +02:00 committed by David Marchand
parent 31f83163cf
commit 3cd73a1a1c
6 changed files with 4 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/test/test_debug.c
View File

@ -66,13 +66,11 @@ test_exit_val(int exit_val)
}
wait(&status);
printf("Child process status: %d\n", status);
#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR
if(!WIFEXITED(status) || WEXITSTATUS(status) != (uint8_t)exit_val){
printf("Child process terminated with incorrect status (expected = %d)!\n",
exit_val);
return -1;
}
#endif
return 0;
}
@ -113,7 +111,6 @@ static int
test_debug(void)
{
rte_dump_stack();
rte_dump_registers();
if (test_panic() < 0)
return -1;
if (test_exit() < 0)

2
doc/guides/howto/debug_troubleshoot.rst
View File

@ -314,7 +314,7 @@ Custom worker function :numref:`dtg_distributor_worker`.
* For high-performance execution logic ensure running it on correct NUMA
and non-master core.
* Analyze run logic with ``rte_dump_stack``, ``rte_dump_registers`` and
* Analyze run logic with ``rte_dump_stack`` and
``rte_memdump`` for more insights.
* Make use of objdump to ensure opcode is matching to the desired state.

2
doc/guides/rel_notes/release_20_11.rst
View File

@ -351,6 +351,8 @@ ABI Changes
Also, make sure to start the actual text at the margin.
=======================================================
* eal: Removed the not implemented function ``rte_dump_registers()``.
* ``ethdev`` changes
* Following device operation function pointers moved

17
lib/librte_eal/common/eal_common_debug.c
View File

@ -7,14 +7,6 @@
#include <rte_log.h>
#include <rte_debug.h>
/* not implemented */
void
rte_dump_registers(void)
{
return;
}
/* call abort(), it will generate a coredump if enabled */
void
__rte_panic(const char *funcname, const char *format, ...)
{
@ -25,8 +17,7 @@ __rte_panic(const char *funcname, const char *format, ...)
rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);
va_end(ap);
rte_dump_stack();
rte_dump_registers();
abort();
abort(); /* generate a coredump if enabled */
}
/*
@ -46,14 +37,8 @@ rte_exit(int exit_code, const char *format, ...)
rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);
va_end(ap);
#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR
if (rte_eal_cleanup() != 0)
RTE_LOG(CRIT, EAL,
"EAL could not release all resources\n");
exit(exit_code);
#else
rte_dump_stack();
rte_dump_registers();
abort();
#endif
}

7
lib/librte_eal/include/rte_debug.h
View File

@ -26,13 +26,6 @@ extern "C" {
*/
void rte_dump_stack(void);
/**
* Dump the registers of the calling core to the console.
*
* Note: Not implemented in a userapp environment; use gdb instead.
*/
void rte_dump_registers(void);
/**
* Provide notification of a critical non-recoverable error and terminate
* execution abnormally.

1
lib/librte_eal/rte_eal_version.map
View File

@ -38,7 +38,6 @@ DPDK_21 {
rte_devargs_remove;
rte_devargs_type_count;
rte_dump_physmem_layout;
rte_dump_registers;
rte_dump_stack;
rte_dump_tailq;
rte_eal_alarm_cancel;