d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

lib: add switch fall-through comments

Browse Source 
With GCC 7 we need to explicitly document when we are falling through from
one switch case to another.

Fixes: af75078fece3 ("first public release")
Fixes: 8bae1da2afe0 ("hash: fallback to software CRC32 implementation")
Fixes: 9ec201f5d6e7 ("mbuf: provide bulk allocation")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
This commit is contained in:
Bruce Richardson 2017-05-04 16:38:18 +01:00 committed by Thomas Monjalon
parent 6104a5224d
commit 3dfb9facb0
3 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/librte_cmdline/cmdline_parse_num.c
View File

@ -250,7 +250,7 @@ cmdline_parse_num(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res,
case HEX: case HEX:
st = HEX_OK; st = HEX_OK;
/* no break */ /* fall-through no break */
case HEX_OK: case HEX_OK:
if (c >= '0' && c <= '9') { if (c >= '0' && c <= '9') {
if (add_to_res(c - '0', &res1, 16) < 0) if (add_to_res(c - '0', &res1, 16) < 0)
@ -282,7 +282,7 @@ cmdline_parse_num(cmdline_parse_token_hdr_t *tk, const char *srcbuf, void *res,
case BIN: case BIN:
st = BIN_OK; st = BIN_OK;
/* no break */ /* fall-through */
case BIN_OK: case BIN_OK:
if (c >= '0' && c <= '1') { if (c >= '0' && c <= '1') {
if (add_to_res(c - '0', &res1, 2) < 0) if (add_to_res(c - '0', &res1, 2) < 0)

6
lib/librte_hash/rte_hash_crc.h
View File

@ -476,9 +476,15 @@ rte_hash_crc_set_alg(uint8_t alg)
case CRC32_SSE42_x64: case CRC32_SSE42_x64:
if (! rte_cpu_get_flag_enabled(RTE_CPUFLAG_EM64T)) if (! rte_cpu_get_flag_enabled(RTE_CPUFLAG_EM64T))
alg = CRC32_SSE42; alg = CRC32_SSE42;
#if __GNUC__ >= 7
__attribute__ ((fallthrough));
#endif
case CRC32_SSE42: case CRC32_SSE42:
if (! rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_2)) if (! rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_2))
alg = CRC32_SW; alg = CRC32_SW;
#if __GNUC__ >= 7
__attribute__ ((fallthrough));
#endif
#endif #endif
case CRC32_SW: case CRC32_SW:
crc32_alg = alg; crc32_alg = alg;

4
lib/librte_mbuf/rte_mbuf.h
View File

@ -1156,21 +1156,25 @@ static inline int rte_pktmbuf_alloc_bulk(struct rte_mempool *pool,
rte_mbuf_refcnt_set(mbufs[idx], 1); rte_mbuf_refcnt_set(mbufs[idx], 1);
rte_pktmbuf_reset(mbufs[idx]); rte_pktmbuf_reset(mbufs[idx]);
idx++; idx++;
/* fall-through */
case 3: case 3:
RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0); RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0);
rte_mbuf_refcnt_set(mbufs[idx], 1); rte_mbuf_refcnt_set(mbufs[idx], 1);
rte_pktmbuf_reset(mbufs[idx]); rte_pktmbuf_reset(mbufs[idx]);
idx++; idx++;
/* fall-through */
case 2: case 2:
RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0); RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0);
rte_mbuf_refcnt_set(mbufs[idx], 1); rte_mbuf_refcnt_set(mbufs[idx], 1);
rte_pktmbuf_reset(mbufs[idx]); rte_pktmbuf_reset(mbufs[idx]);
idx++; idx++;
/* fall-through */
case 1: case 1:
RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0); RTE_ASSERT(rte_mbuf_refcnt_read(mbufs[idx]) == 0);
rte_mbuf_refcnt_set(mbufs[idx], 1); rte_mbuf_refcnt_set(mbufs[idx], 1);
rte_pktmbuf_reset(mbufs[idx]); rte_pktmbuf_reset(mbufs[idx]);
idx++; idx++;
/* fall-through */
} }
} }
return 0; return 0;