d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bus/vdev: fix crash in device cleanup

Browse Source 
vdev_probe calls driver->probe and set dev->device.driver,
which will be NULL if the probe fails.

In vdev_cleanup, drv = container_of(dev->device.driver)
drv will be !NULL in this case, causing drv->remove
Segmentation fault.

Fixed by checking dev->device.driver before.

Log:
$ sudo dpdk-test --vdev=crypto_uadk --log-level=6
vdev_probe(): failed to initialize crypto_uadk device
EAL: Bus (vdev) probe failed.
RTE>>quit
Segmentation fault

Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")

Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
This commit is contained in:
Zhangfei Gao 2022-10-19 22:08:01 +08:00 committed by David Marchand
parent d5c398741d
commit 3f27defe0c
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/bus/vdev/vdev.c
View File

@ -577,9 +577,12 @@ vdev_cleanup(void)
const struct rte_vdev_driver *drv; const struct rte_vdev_driver *drv;
int ret = 0; int ret = 0;
if (dev->device.driver == NULL)
continue;
drv = container_of(dev->device.driver, const struct rte_vdev_driver, driver); drv = container_of(dev->device.driver, const struct rte_vdev_driver, driver);
if (drv == NULL || drv->remove == NULL) if (drv->remove == NULL)
continue; continue;
ret = drv->remove(dev); ret = drv->remove(dev);