d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/enic: fix dereference before null check

Browse Source 
This patch fixes an issue found by coverity. It checks for a possible
null value of "error" before dereferencing it.

CID: 375064: Dereference after null check
Either the check against null is unnecessary, or there may be a null
pointer dereference.

Coverity issue: 375064
Fixes: ee806eea59 ("net/enic: support GENEVE flow item")

Signed-off-by: John Daley <johndale@cisco.com>
Reviewed-by: Hyong Youb Kim <hyonkim@cisco.com>
This commit is contained in:
John Daley 2022-02-14 12:46:10 -08:00 committed by Ferruh Yigit
parent 3f3ae64f14
commit 3f326c460f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/enic/enic_fm_flow.c
View File

@ -1204,7 +1204,7 @@ enic_fm_copy_entry(struct enic_flowman *fm,
ret = item_info->copy_item(&args);
if (ret) {
/* If copy_item set the error, return that */
if (error->type != RTE_FLOW_ERROR_TYPE_NONE)
if (error && error->type != RTE_FLOW_ERROR_TYPE_NONE)
return ret;
goto item_not_supported;
}