d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eal: move runtime directory creation after args parsing

Browse Source 
The intention of the original code was to create runtime data
directory as early as possible, however it was moved too early,
before the arguments were parsed, resulting in --file-prefix
option essentially not working.

Fix this by moving eal_create_runtime_dir() to after command
line arguments parsing.

Fixes: 56236363b4 ("eal: add directory for runtime data")

Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
This commit is contained in:
Anatoly Burakov 2018-05-15 11:44:52 +01:00 committed by Thomas Monjalon
parent 52f711f7b8
commit 3f697d2ee5
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/librte_eal/bsdapp/eal/eal.c
View File

@ -586,13 +586,6 @@ rte_eal_init(int argc, char **argv)
/* set log level as early as possible */
eal_log_level_parse(argc, argv);
/* create runtime data directory */
if (eal_create_runtime_dir() < 0) {
rte_eal_init_alert("Cannot create runtime directory\n");
rte_errno = EACCES;
return -1;
}
if (rte_eal_cpu_init() < 0) {
rte_eal_init_alert("Cannot detect lcores.");
rte_errno = ENOTSUP;
@ -607,6 +600,13 @@ rte_eal_init(int argc, char **argv)
return -1;
}
/* create runtime data directory */
if (eal_create_runtime_dir() < 0) {
rte_eal_init_alert("Cannot create runtime directory\n");
rte_errno = EACCES;
return -1;
}
/* FreeBSD always uses legacy memory model */
internal_config.legacy_mem = true;

14
lib/librte_eal/linuxapp/eal/eal.c
View File

@ -803,13 +803,6 @@ rte_eal_init(int argc, char **argv)
/* set log level as early as possible */
eal_log_level_parse(argc, argv);
/* create runtime data directory */
if (eal_create_runtime_dir() < 0) {
rte_eal_init_alert("Cannot create runtime directory\n");
rte_errno = EACCES;
return -1;
}
if (rte_eal_cpu_init() < 0) {
rte_eal_init_alert("Cannot detect lcores.");
rte_errno = ENOTSUP;
@ -824,6 +817,13 @@ rte_eal_init(int argc, char **argv)
return -1;
}
/* create runtime data directory */
if (eal_create_runtime_dir() < 0) {
rte_eal_init_alert("Cannot create runtime directory\n");
rte_errno = EACCES;
return -1;
}
if (eal_plugins_init() < 0) {
rte_eal_init_alert("Cannot init plugins\n");
rte_errno = EINVAL;