d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eal/bsd: silence unsupported interrupts error

Browse Source 
Currently, nic_uio driver does not support interrupts, so any
attempts to install an interrupt handler will fail with a
not supported error, which will cause an error message that is
confusing to the user.

Silence this error by moving it to debug log level, and reword
the message to avoid containing the word "Error", to avoid
triggering DTS test failures [1].

[1] https://git.dpdk.org/tools/dts/tree/tests/TestSuite_scatter.py?#n110

Fixes: 23150bd8d8 ("eal/bsd: add interrupt thread")

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
This commit is contained in:
Anatoly Burakov 2018-07-27 09:24:35 +01:00 committed by Thomas Monjalon
parent 45fdc3ed87
commit 4268cf49e8
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/librte_eal/bsdapp/eal/eal_interrupts.c
View File

@ -156,8 +156,18 @@ rte_intr_callback_register(const struct rte_intr_handle *intr_handle,
* add the intr file descriptor into wait list.
*/
if (kevent(kq, &ke, 1, NULL, 0, NULL) < 0) {
RTE_LOG(ERR, EAL, "Error adding fd %d kevent, %s\n",
src->intr_handle.fd, strerror(errno));
/* currently, nic_uio does not support interrupts, so
* this error will always be triggered and output to the
* user. so, don't output it unless debug log level set.
*/
if (errno == ENODEV)
RTE_LOG(DEBUG, EAL, "Interrupt handle %d not supported\n",
src->intr_handle.fd);
else
RTE_LOG(ERR, EAL, "Error adding fd %d "
"kevent, %s\n",
src->intr_handle.fd,
strerror(errno));
ret = -errno;
goto fail;
}