d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pcapng: handle failure of link status query

Browse Source 
If rte_ethlink_get fails, the code can just not add speed
to the pcap file.

Coverity issue: 373664
Fixes: 8d23ce8f5e ("pcapng: add new library for writing pcapng files")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This commit is contained in:
Stephen Hemminger 2022-02-10 15:09:04 -08:00 committed by Thomas Monjalon
parent a8a1c40bda
commit 442878db2e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/pcapng/rte_pcapng.c
View File

@ -176,8 +176,8 @@ pcapng_add_interface(rte_pcapng_t *self, uint16_t port)
"%s-%s", dev->bus->name, dev->name);
/* DPDK reports in units of Mbps */
rte_eth_link_get(port, &link);
if (link.link_status == RTE_ETH_LINK_UP)
if (rte_eth_link_get(port, &link) == 0 &&
link.link_status == RTE_ETH_LINK_UP)
speed = link.link_speed * PCAPNG_MBPS_SPEED;
if (rte_eth_macaddr_get(port, &macaddr) < 0)