d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/bnxt: remove software prefetches from AVX2 Rx

Browse Source 
Testing has shown no performance benefit from software prefetching
of receive completion descriptors in the AVX2 burst receive path,
and slightly better performance without them on some CPU families,
so this patch removes them.

Fixes: c4e4c18963b0 ("net/bnxt: add AVX2 RX/Tx")
Cc: stable@dpdk.org

Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
This commit is contained in:
Lance Richardson 2021-11-15 13:24:10 -05:00 committed by Ajit Khaparde
parent e5f2b3ebcb
commit 4641de7b02
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/net/bnxt/bnxt_rxtx_vec_avx2.c
View File

@ -92,12 +92,6 @@ recv_burst_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
cons = raw_cons & (cp_ring_size - 1);
mbcons = (raw_cons / 2) & (rx_ring_size - 1);
/* Prefetch first four descriptor pairs. */
rte_prefetch0(&cp_desc_ring[cons + 0]);
rte_prefetch0(&cp_desc_ring[cons + 4]);
rte_prefetch0(&cp_desc_ring[cons + 8]);
rte_prefetch0(&cp_desc_ring[cons + 12]);
/* Return immediately if there is not at least one completed packet. */
if (!bnxt_cpr_cmp_valid(&cp_desc_ring[cons], raw_cons, cp_ring_size))
return 0;
@ -136,14 +130,6 @@ recv_burst_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
_mm256_storeu_si256((void *)&rx_pkts[i + 4], t0);
#endif
/* Prefetch eight descriptor pairs for next iteration. */
if (i + BNXT_RX_DESCS_PER_LOOP_VEC256 < nb_pkts) {
rte_prefetch0(&cp_desc_ring[cons + 16]);
rte_prefetch0(&cp_desc_ring[cons + 20]);
rte_prefetch0(&cp_desc_ring[cons + 24]);
rte_prefetch0(&cp_desc_ring[cons + 28]);
}
/*
* Load eight receive completion descriptors into 256-bit
* registers. Loads are issued in reverse order in order to