eal: fix memory leak when saving arguments

This patch fixes a memleak which was reported in Bugzilla within the
eal_save_args function. This was caused by the function mistakenly
adding -- to the eal args instead of breaking beforehand.

Bugzilla ID: 722
Fixes: 293c53d8b2 ("eal: add telemetry callbacks")

Reported-by: Zhihong Peng <zhihongx.peng@intel.com>
Signed-off-by: Conor Walsh <conor.walsh@intel.com>
Signed-off-by: Conor Fogarty <conor.fogarty@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
This commit is contained in:
Conor Walsh 2021-09-01 09:38:47 +00:00 committed by David Marchand
parent e7ef133d77
commit 4777674c44

View File

@ -223,9 +223,9 @@ eal_save_args(int argc, char **argv)
return -1;
for (i = 0; i < argc; i++) {
eal_args[i] = strdup(argv[i]);
if (strcmp(argv[i], "--") == 0)
break;
eal_args[i] = strdup(argv[i]);
}
eal_args[i++] = NULL; /* always finish with NULL */