d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ethdev: explicit some errors of port start and stop

Browse Source 
This patch clarifies the handling of following cases
in the ethdev API docs:

- If rte_eth_dev_start() returns (-EAGAIN) for some port,
  it cannot be started right now and start operation
  must be retried.
- If rte_eth_dev_stop() returns (-EBUSY) for some port,
  it cannot be stopped in the current state.

When stopping the port in testpmd fails,
port's state is switched back to STARTED
to allow users to manually retry stopping the port.

No additional changes in testpmd are required to handle
failures to start the port.
If rte_eth_dev_start() fails, port's state is switched to STOPPED
and users are allowed to retry the operation.

Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
This commit is contained in:
Dariusz Sosnowski 2022-11-14 18:19:56 +00:00 committed by Thomas Monjalon
parent 8e82ebe265
commit 47a4e1fb2c
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/test-pmd/testpmd.c
View File

@ -3182,6 +3182,7 @@ stop_port(portid_t pid)
int need_check_link_status = 0;
portid_t peer_pl[RTE_MAX_ETHPORTS];
int peer_pi;
int ret;
if (port_id_is_invalid(pid, ENABLED_WARN))
return;
@ -3231,9 +3232,14 @@ stop_port(portid_t pid)
if (port->flow_list)
port_flow_flush(pi);
if (eth_dev_stop_mp(pi) != 0)
ret = eth_dev_stop_mp(pi);
if (ret != 0) {
RTE_LOG(ERR, EAL, "rte_eth_dev_stop failed for port %u\n",
pi);
/* Allow to retry stopping the port. */
port->port_status = RTE_PORT_STARTED;
continue;
}
if (port->port_status == RTE_PORT_HANDLING)
port->port_status = RTE_PORT_STOPPED;

2
lib/ethdev/rte_ethdev.h
View File

@ -2705,6 +2705,7 @@ int rte_eth_dev_tx_queue_stop(uint16_t port_id, uint16_t tx_queue_id);
* The port identifier of the Ethernet device.
* @return
* - 0: Success, Ethernet device started.
* - -EAGAIN: If start operation must be retried.
* - <0: Error code of the driver device start function.
*/
int rte_eth_dev_start(uint16_t port_id);
@ -2717,6 +2718,7 @@ int rte_eth_dev_start(uint16_t port_id);
* The port identifier of the Ethernet device.
* @return
* - 0: Success, Ethernet device stopped.
* - -EBUSY: If stopping the port is not allowed in current state.
* - <0: Error code of the driver device stop function.
*/
int rte_eth_dev_stop(uint16_t port_id);