d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/mlx4: fix RSS action with null hash key

Browse Source 
If RSS action contains non zero hash key length and NULL
key buffer pointer the default hash key should be used.
The check for the NULL pointer this was missing in the mlx4
PMD causing crash, for example, in testpmd with command:

flow validate 0 ingress group 0
  pattern eth / ipv4 / end
  actions rss queues 0 end key_len 40 / end

Fixes: ac8d22de23 ("ethdev: flatten RSS configuration in flow API")
Cc: stable@dpdk.org

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
This commit is contained in:
Viacheslav Ovsiienko 2021-04-07 15:30:15 +00:00 committed by Raslan Darawsheh
parent cb299214a6
commit 4a750d2992
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/mlx4/mlx4_flow.c
View File

@ -791,7 +791,8 @@ mlx4_flow_prepare(struct mlx4_priv *priv,
rss = action->conf;
/* Default RSS configuration if none is provided. */
if (rss->key_len) {
rss_key = rss->key;
rss_key = rss->key ?
rss->key : mlx4_rss_hash_key_default;
rss_key_len = rss->key_len;
} else {
rss_key = mlx4_rss_hash_key_default;