From 4ccd42591f2fc0aba95c6b5fb18adb50dde99d66 Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Fri, 1 Nov 2019 15:21:42 +0000 Subject: [PATCH] test/fib: add autotests Functional tests for the new FIB library. Signed-off-by: Vladimir Medvedkin --- MAINTAINERS | 1 + app/test/Makefile | 1 + app/test/autotest_data.py | 12 ++ app/test/meson.build | 4 + app/test/test_fib.c | 414 ++++++++++++++++++++++++++++++++++++++ 5 files changed, 432 insertions(+) create mode 100644 app/test/test_fib.c diff --git a/MAINTAINERS b/MAINTAINERS index 7cc5e25f47..c67b5f3f68 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1322,6 +1322,7 @@ M: Vladimir Medvedkin F: lib/librte_rib/ F: app/test/test_rib* F: lib/librte_fib/ +F: app/test/test_fib* Traffic metering M: Cristian Dumitrescu diff --git a/app/test/Makefile b/app/test/Makefile index 00089e9772..a22532d3e7 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -126,6 +126,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_HASH) += test_hash_readwrite_lf.c SRCS-$(CONFIG_RTE_LIBRTE_RIB) += test_rib.c SRCS-$(CONFIG_RTE_LIBRTE_RIB) += test_rib6.c +SRCS-$(CONFIG_RTE_LIBRTE_FIB) += test_fib.c SRCS-$(CONFIG_RTE_LIBRTE_LPM) += test_lpm.c SRCS-$(CONFIG_RTE_LIBRTE_LPM) += test_lpm_perf.c diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py index 461ab07160..c82fda2794 100644 --- a/app/test/autotest_data.py +++ b/app/test/autotest_data.py @@ -122,6 +122,18 @@ "Func": default_autotest, "Report": None, }, + { + "Name": "FIB autotest", + "Command": "fib_autotest", + "Func": default_autotest, + "Report": None, + }, + { + "Name": "FIB slow autotest", + "Command": "fib_slow_autotest", + "Func": default_autotest, + "Report": None, + }, { "Name": "Memcpy autotest", "Command": "memcpy_autotest", diff --git a/app/test/meson.build b/app/test/meson.build index 2f1438714e..85048c0ad7 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -48,6 +48,7 @@ test_sources = files('commands.c', 'test_eventdev.c', 'test_external_mem.c', 'test_fbarray.c', + 'test_fib.c', 'test_func_reentrancy.c', 'test_flow_classify.c', 'test_hash.c', @@ -139,6 +140,7 @@ test_deps = ['acl', 'efd', 'ethdev', 'eventdev', + 'fib', 'flow_classify', 'hash', 'ipsec', @@ -182,6 +184,7 @@ fast_test_names = [ 'eal_fs_autotest', 'errno_autotest', 'event_ring_autotest', + 'fib_autotest', 'func_reentrancy_autotest', 'flow_classify_autotest', 'hash_autotest', @@ -252,6 +255,7 @@ perf_test_names = [ 'reciprocal_division', 'reciprocal_division_perf', 'lpm_perf_autotest', + 'fib_slow_autotest', 'red_all', 'barrier_autotest', 'hash_multiwriter_autotest', diff --git a/app/test/test_fib.c b/app/test/test_fib.c new file mode 100644 index 0000000000..ca80a5dd2f --- /dev/null +++ b/app/test/test_fib.c @@ -0,0 +1,414 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2018 Vladimir Medvedkin + * Copyright(c) 2019 Intel Corporation + */ + +#include +#include +#include + +#include +#include +#include + +#include "test.h" + +typedef int32_t (*rte_fib_test)(void); + +static int32_t test_create_invalid(void); +static int32_t test_multiple_create(void); +static int32_t test_free_null(void); +static int32_t test_add_del_invalid(void); +static int32_t test_get_invalid(void); +static int32_t test_lookup(void); + +#define MAX_ROUTES (1 << 16) +#define MAX_TBL8 (1 << 15) + +/* + * Check that rte_fib_create fails gracefully for incorrect user input + * arguments + */ +int32_t +test_create_invalid(void) +{ + struct rte_fib *fib = NULL; + struct rte_fib_conf config; + + config.max_routes = MAX_ROUTES; + config.default_nh = 0; + config.type = RTE_FIB_DUMMY; + + /* rte_fib_create: fib name == NULL */ + fib = rte_fib_create(NULL, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib == NULL, + "Call succeeded with invalid parameters\n"); + + /* rte_fib_create: config == NULL */ + fib = rte_fib_create(__func__, SOCKET_ID_ANY, NULL); + RTE_TEST_ASSERT(fib == NULL, + "Call succeeded with invalid parameters\n"); + + /* socket_id < -1 is invalid */ + fib = rte_fib_create(__func__, -2, &config); + RTE_TEST_ASSERT(fib == NULL, + "Call succeeded with invalid parameters\n"); + + /* rte_fib_create: max_routes = 0 */ + config.max_routes = 0; + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib == NULL, + "Call succeeded with invalid parameters\n"); + config.max_routes = MAX_ROUTES; + + config.type = RTE_FIB_TYPE_MAX; + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib == NULL, + "Call succeeded with invalid parameters\n"); + + config.type = RTE_FIB_DIR24_8; + config.dir24_8.num_tbl8 = MAX_TBL8; + + config.dir24_8.nh_sz = RTE_FIB_DIR24_8_8B + 1; + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib == NULL, + "Call succeeded with invalid parameters\n"); + config.dir24_8.nh_sz = RTE_FIB_DIR24_8_8B; + + config.dir24_8.num_tbl8 = 0; + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib == NULL, + "Call succeeded with invalid parameters\n"); + + return TEST_SUCCESS; +} + +/* + * Create fib table then delete fib table 10 times + * Use a slightly different rules size each time + */ +int32_t +test_multiple_create(void) +{ + struct rte_fib *fib = NULL; + struct rte_fib_conf config; + int32_t i; + + config.default_nh = 0; + config.type = RTE_FIB_DUMMY; + + for (i = 0; i < 100; i++) { + config.max_routes = MAX_ROUTES - i; + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib != NULL, "Failed to create FIB\n"); + rte_fib_free(fib); + } + /* Can not test free so return success */ + return TEST_SUCCESS; +} + +/* + * Call rte_fib_free for NULL pointer user input. Note: free has no return and + * therefore it is impossible to check for failure but this test is added to + * increase function coverage metrics and to validate that freeing null does + * not crash. + */ +int32_t +test_free_null(void) +{ + struct rte_fib *fib = NULL; + struct rte_fib_conf config; + + config.max_routes = MAX_ROUTES; + config.default_nh = 0; + config.type = RTE_FIB_DUMMY; + + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib != NULL, "Failed to create FIB\n"); + + rte_fib_free(fib); + rte_fib_free(NULL); + return TEST_SUCCESS; +} + +/* + * Check that rte_fib_add and rte_fib_delete fails gracefully + * for incorrect user input arguments + */ +int32_t +test_add_del_invalid(void) +{ + struct rte_fib *fib = NULL; + struct rte_fib_conf config; + uint64_t nh = 100; + uint32_t ip = RTE_IPV4(0, 0, 0, 0); + int ret; + uint8_t depth = 24; + + config.max_routes = MAX_ROUTES; + config.default_nh = 0; + config.type = RTE_FIB_DUMMY; + + /* rte_fib_add: fib == NULL */ + ret = rte_fib_add(NULL, ip, depth, nh); + RTE_TEST_ASSERT(ret < 0, + "Call succeeded with invalid parameters\n"); + + /* rte_fib_delete: fib == NULL */ + ret = rte_fib_delete(NULL, ip, depth); + RTE_TEST_ASSERT(ret < 0, + "Call succeeded with invalid parameters\n"); + + /*Create valid fib to use in rest of test. */ + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib != NULL, "Failed to create FIB\n"); + + /* rte_fib_add: depth > RTE_FIB_MAXDEPTH */ + ret = rte_fib_add(fib, ip, RTE_FIB_MAXDEPTH + 1, nh); + RTE_TEST_ASSERT(ret < 0, + "Call succeeded with invalid parameters\n"); + + /* rte_fib_delete: depth > RTE_FIB_MAXDEPTH */ + ret = rte_fib_delete(fib, ip, RTE_FIB_MAXDEPTH + 1); + RTE_TEST_ASSERT(ret < 0, + "Call succeeded with invalid parameters\n"); + + rte_fib_free(fib); + + return TEST_SUCCESS; +} + +/* + * Check that rte_fib_get_dp and rte_fib_get_rib fails gracefully + * for incorrect user input arguments + */ +int32_t +test_get_invalid(void) +{ + void *p; + + p = rte_fib_get_dp(NULL); + RTE_TEST_ASSERT(p == NULL, + "Call succeeded with invalid parameters\n"); + + p = rte_fib_get_rib(NULL); + RTE_TEST_ASSERT(p == NULL, + "Call succeeded with invalid parameters\n"); + + return TEST_SUCCESS; +} + +/* + * Add routes for one supernet with all possible depths and do lookup + * on each step + * After delete routes with doing lookup on each step + */ +static int +lookup_and_check_asc(struct rte_fib *fib, uint32_t ip_arr[RTE_FIB_MAXDEPTH], + uint32_t ip_missing, uint64_t def_nh, uint32_t n) +{ + uint64_t nh_arr[RTE_FIB_MAXDEPTH]; + int ret; + uint32_t i = 0; + + ret = rte_fib_lookup_bulk(fib, ip_arr, nh_arr, RTE_FIB_MAXDEPTH); + RTE_TEST_ASSERT(ret == 0, "Failed to lookup\n"); + + for (; i <= RTE_FIB_MAXDEPTH - n; i++) + RTE_TEST_ASSERT(nh_arr[i] == n, + "Failed to get proper nexthop\n"); + + for (; i < RTE_FIB_MAXDEPTH; i++) + RTE_TEST_ASSERT(nh_arr[i] == --n, + "Failed to get proper nexthop\n"); + + ret = rte_fib_lookup_bulk(fib, &ip_missing, nh_arr, 1); + RTE_TEST_ASSERT((ret == 0) && (nh_arr[0] == def_nh), + "Failed to get proper nexthop\n"); + + return TEST_SUCCESS; +} + +static int +lookup_and_check_desc(struct rte_fib *fib, uint32_t ip_arr[RTE_FIB_MAXDEPTH], + uint32_t ip_missing, uint64_t def_nh, uint32_t n) +{ + uint64_t nh_arr[RTE_FIB_MAXDEPTH]; + int ret; + uint32_t i = 0; + + ret = rte_fib_lookup_bulk(fib, ip_arr, nh_arr, RTE_FIB_MAXDEPTH); + RTE_TEST_ASSERT(ret == 0, "Failed to lookup\n"); + + for (; i < n; i++) + RTE_TEST_ASSERT(nh_arr[i] == RTE_FIB_MAXDEPTH - i, + "Failed to get proper nexthop\n"); + + for (; i < RTE_FIB_MAXDEPTH; i++) + RTE_TEST_ASSERT(nh_arr[i] == def_nh, + "Failed to get proper nexthop\n"); + + ret = rte_fib_lookup_bulk(fib, &ip_missing, nh_arr, 1); + RTE_TEST_ASSERT((ret == 0) && (nh_arr[0] == def_nh), + "Failed to get proper nexthop\n"); + + return TEST_SUCCESS; +} + +static int +check_fib(struct rte_fib *fib) +{ + uint64_t def_nh = 100; + uint32_t ip_arr[RTE_FIB_MAXDEPTH]; + uint32_t ip_add = RTE_IPV4(128, 0, 0, 0); + uint32_t i, ip_missing = RTE_IPV4(127, 255, 255, 255); + int ret; + + for (i = 0; i < RTE_FIB_MAXDEPTH; i++) + ip_arr[i] = ip_add + (1ULL << i) - 1; + + ret = lookup_and_check_desc(fib, ip_arr, ip_missing, def_nh, 0); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, "Lookup and check fails\n"); + + for (i = 1; i <= RTE_FIB_MAXDEPTH; i++) { + ret = rte_fib_add(fib, ip_add, i, i); + RTE_TEST_ASSERT(ret == 0, "Failed to add a route\n"); + ret = lookup_and_check_asc(fib, ip_arr, ip_missing, + def_nh, i); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, "Lookup and check fails\n"); + } + + for (i = RTE_FIB_MAXDEPTH; i > 1; i--) { + ret = rte_fib_delete(fib, ip_add, i); + RTE_TEST_ASSERT(ret == 0, "Failed to delete a route\n"); + ret = lookup_and_check_asc(fib, ip_arr, ip_missing, + def_nh, i - 1); + + RTE_TEST_ASSERT(ret == TEST_SUCCESS, "Lookup and check fails\n"); + } + ret = rte_fib_delete(fib, ip_add, i); + RTE_TEST_ASSERT(ret == 0, "Failed to delete a route\n"); + ret = lookup_and_check_desc(fib, ip_arr, ip_missing, def_nh, 0); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, "Lookup and check fails\n"); + + for (i = 0; i < RTE_FIB_MAXDEPTH; i++) { + ret = rte_fib_add(fib, ip_add, RTE_FIB_MAXDEPTH - i, + RTE_FIB_MAXDEPTH - i); + RTE_TEST_ASSERT(ret == 0, "Failed to add a route\n"); + ret = lookup_and_check_desc(fib, ip_arr, ip_missing, + def_nh, i + 1); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, "Lookup and check fails\n"); + } + + for (i = 1; i <= RTE_FIB_MAXDEPTH; i++) { + ret = rte_fib_delete(fib, ip_add, i); + RTE_TEST_ASSERT(ret == 0, "Failed to delete a route\n"); + ret = lookup_and_check_desc(fib, ip_arr, ip_missing, def_nh, + RTE_FIB_MAXDEPTH - i); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, "Lookup and check fails\n"); + } + + return TEST_SUCCESS; +} + +int32_t +test_lookup(void) +{ + struct rte_fib *fib = NULL; + struct rte_fib_conf config; + uint64_t def_nh = 100; + int ret; + + config.max_routes = MAX_ROUTES; + config.default_nh = def_nh; + config.type = RTE_FIB_DUMMY; + + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib != NULL, "Failed to create FIB\n"); + ret = check_fib(fib); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, + "Check_fib fails for DUMMY type\n"); + rte_fib_free(fib); + + config.type = RTE_FIB_DIR24_8; + + config.dir24_8.nh_sz = RTE_FIB_DIR24_8_1B; + config.dir24_8.num_tbl8 = 127; + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib != NULL, "Failed to create FIB\n"); + ret = check_fib(fib); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, + "Check_fib fails for DIR24_8_1B type\n"); + rte_fib_free(fib); + + config.dir24_8.nh_sz = RTE_FIB_DIR24_8_2B; + config.dir24_8.num_tbl8 = MAX_TBL8 - 1; + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib != NULL, "Failed to create FIB\n"); + ret = check_fib(fib); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, + "Check_fib fails for DIR24_8_2B type\n"); + rte_fib_free(fib); + + config.dir24_8.nh_sz = RTE_FIB_DIR24_8_4B; + config.dir24_8.num_tbl8 = MAX_TBL8; + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib != NULL, "Failed to create FIB\n"); + ret = check_fib(fib); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, + "Check_fib fails for DIR24_8_4B type\n"); + rte_fib_free(fib); + + config.dir24_8.nh_sz = RTE_FIB_DIR24_8_8B; + config.dir24_8.num_tbl8 = MAX_TBL8; + fib = rte_fib_create(__func__, SOCKET_ID_ANY, &config); + RTE_TEST_ASSERT(fib != NULL, "Failed to create FIB\n"); + ret = check_fib(fib); + RTE_TEST_ASSERT(ret == TEST_SUCCESS, + "Check_fib fails for DIR24_8_8B type\n"); + rte_fib_free(fib); + + return TEST_SUCCESS; +} + +static struct unit_test_suite fib_fast_tests = { + .suite_name = "fib autotest", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_create_invalid), + TEST_CASE(test_free_null), + TEST_CASE(test_add_del_invalid), + TEST_CASE(test_get_invalid), + TEST_CASE(test_lookup), + TEST_CASES_END() + } +}; + +static struct unit_test_suite fib_slow_tests = { + .suite_name = "fib slow autotest", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_multiple_create), + TEST_CASES_END() + } +}; + +/* + * Do all unit tests. + */ +static int +test_fib(void) +{ + return unit_test_suite_runner(&fib_fast_tests); +} + +static int +test_slow_fib(void) +{ + return unit_test_suite_runner(&fib_slow_tests); +} + +REGISTER_TEST_COMMAND(fib_autotest, test_fib); +REGISTER_TEST_COMMAND(fib_slow_autotest, test_slow_fib);