From 4eadb8ba11b7b0764662f9da929e9c642cfe8966 Mon Sep 17 00:00:00 2001 From: Maryam Tahhan Date: Tue, 20 Oct 2015 11:34:18 +0100 Subject: [PATCH] ethdev: do not deprecate imissed counter Remove the deprecation tag and notice for imissed as it is a generic register that accounts for packets that were dropped by the HW, because there are no available mbufs (RX queues are full). imissed is different to ierrors and can help with general debug. Fixes: 49f386542af4 ("ethdev: remove driver specific stats") Signed-off-by: Maryam Tahhan --- doc/guides/rel_notes/deprecation.rst | 2 +- lib/librte_ether/rte_ethdev.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index a391ff091d..f099ac0333 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -14,7 +14,7 @@ Deprecation Notices All binaries will need to be rebuilt from release 2.2. * The following fields have been deprecated in rte_eth_stats: - imissed, ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, + ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff * ABI changes are planned for struct rte_eth_fdir_flow_ext in order to support diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index c835a2f565..7cf4af8634 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -195,7 +195,9 @@ struct rte_eth_stats { uint64_t ibytes; /**< Total number of successfully received bytes. */ uint64_t obytes; /**< Total number of successfully transmitted bytes. */ uint64_t imissed; - /**< Deprecated; Total of RX missed packets (e.g full FIFO). */ + /**< Total of RX packets dropped by the HW, + * because there are no available mbufs (i.e. RX queues are full). + */ uint64_t ibadcrc; /**< Deprecated; Total of RX packets with CRC error. */ uint64_t ibadlen;