d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/hns3: fix default error code of command interface

Browse Source 
Currently, the hns3 PMD driver can interact with firmware through
command to complete hardware configuration. The driver calls internal
interface function named hns3_cmd_send to issues command to the
firmware, and check the execution result of the command through desc_ret
returned by firmware to driver.

As the design of error code, when device is resetting hns3_cmd_send will
only return -EBUSY or -EIO. But we found that if desc_ret is in
[12,65535], for example the item doesn't exist when issuing the command
to query some table item, hns3_cmd_send also return -EIO. This
phenomenon will affect the processing logic for the return value.

The root cause as below:
When desc_ret is in [12,65535], in the static function named
hns3_cmd_convert_err_code called by hns3_cmd_send, matches the default
case and return -EIO. And then hns3_cmd_send return -EIO.

This patch fixes it with the following modification.
1. Change the return value of the default case in the static function
   named hns3_cmd_convert_err_code from -EIO to -EREMOTEIO.
2. Modify the comment add errcode description of the internal interface
   function named hns3_cmd_send.

Fixes: 737f30e1c3ab ("net/hns3: support command interface with firmware")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
This commit is contained in:
Chengwen Feng 2020-03-17 17:12:03 +08:00 committed by Ferruh Yigit
parent af531efa4b
commit 4f4ee5b79b
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/net/hns3/hns3_cmd.c
View File

@ -289,7 +289,7 @@ hns3_cmd_convert_err_code(uint16_t desc_ret)
case HNS3_CMD_INVALID:
return -EBADR;
default:
return -EIO;
return -EREMOTEIO;
}
}
@ -349,11 +349,23 @@ static int hns3_cmd_poll_reply(struct hns3_hw *hw)
/*
* hns3_cmd_send - send command to command queue
* @hw: pointer to the hw struct
* @desc: prefilled descriptor for describing the command
* @num : the number of descriptors to be sent
*
* This is the main send command for command queue, it
* @param hw
* pointer to the hw struct
* @param desc
* prefilled descriptor for describing the command
* @param num
* the number of descriptors to be sent
* @return
* - -EBUSY if detect device is in resetting
* - -EIO if detect cmd csq corrupted (due to reset) or
* there is reset pending
* - -ENOMEM/-ETIME/...(Non-Zero) if other error case
* - Zero if operation completed successfully
*
* Note -BUSY/-EIO only used in reset case
*
* Note this is the main send command for command queue, it
* sends the queue, cleans the queue, etc
*/
int