d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pci: propagate PMD removal error value for unplug

Browse Source 
If a PCI device detach removal fails, returns the actual removal
operator error value.

Use this value within pci->unplug, as it may help applications solve an
issue with the feature or more accurately warn their users.

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
This commit is contained in:
Gaetan Rivet 2017-10-24 12:35:39 +02:00 committed by Ferruh Yigit
parent 00a3d8104a
commit 51093e679b
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/librte_eal/common/eal_common_pci.c
View File

@ -263,6 +263,7 @@ rte_pci_detach_dev(struct rte_pci_device *dev)
{
struct rte_pci_addr *loc;
struct rte_pci_driver *dr;
int ret = 0;
if (dev == NULL)
return -EINVAL;
@ -277,8 +278,11 @@ rte_pci_detach_dev(struct rte_pci_device *dev)
RTE_LOG(DEBUG, EAL, " remove driver: %x:%x %s\n", dev->id.vendor_id,
dev->id.device_id, dr->driver.name);
if (dr->remove && (dr->remove(dev) < 0))
return -1; /* negative value is an error */
if (dr->remove) {
ret = dr->remove(dev);
if (ret < 0)
return ret;
}
/* clear driver structure */
dev->driver = NULL;
@ -551,8 +555,10 @@ pci_unplug(struct rte_device *dev)
pdev = RTE_DEV_TO_PCI(dev);
ret = rte_pci_detach_dev(pdev);
rte_pci_remove_device(pdev);
free(pdev);
if (ret == 0) {
rte_pci_remove_device(pdev);
free(pdev);
}
return ret;
}