d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hash: fix total entries count

Browse Source 
In rte_hash, with current implementation, it is possible that keys
are stored at indexes greater than the number of total entries.

Currently, in rte_hash_free_key_with_position(), due to incorrect
computation of total_entries, application cannot free keys with
indexes greater than the number of total entries.

This patch fixes this incorrect computation of total_entries.

Bugzilla ID: 261
Fixes: 9d033dac7d7c ("hash: support no free on delete")
Cc: stable@dpdk.org

Reported-by: Linfan <zhongdahulinfan@163.com>
Suggested-by: Linfan <zhongdahulinfan@163.com>
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
This commit is contained in:
Dharmik Thakkar 2019-05-09 17:19:06 +00:00 committed by Thomas Monjalon
parent 2bc731197b
commit 52c7abbea9
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/librte_hash/rte_cuckoo_hash.c
View File

@ -1594,7 +1594,9 @@ rte_hash_free_key_with_position(const struct rte_hash *h,
unsigned int lcore_id, n_slots;
struct lcore_cache *cached_free_slots;
const uint32_t total_entries = h->num_buckets * RTE_HASH_BUCKET_ENTRIES;
const uint32_t total_entries = h->use_local_cache ?
h->entries + (RTE_MAX_LCORE - 1) * (LCORE_CACHE_SIZE - 1) + 1
: h->entries + 1;
/* Out of bounds */
if (key_idx >= total_entries)