From 53caecb8445b3dce4cb7bae235ad6023a828577c Mon Sep 17 00:00:00 2001 From: Konstantin Ananyev Date: Tue, 26 Oct 2021 12:53:01 +0100 Subject: [PATCH] pdump: fix freeing statistics memzone rte_pdump_init() always allocates new memzone for pdump_stats. Though rte_pdump_uninit() never frees it. So the following combination will always fail: rte_pdump_init(); rte_pdump_uninit(); rte_pdump_init(); The issue was caught by pdump_autotest UT. While first test run successful, any consecutive runs of this test-case will fail. Fix the issue by calling rte_memzone_free() for statistics memzone. Fixes: 10f726efe26c ("pdump: support pcapng and filtering") Signed-off-by: Konstantin Ananyev Acked-by: Reshma Pattan Acked-by: Stephen Hemminger --- lib/pdump/rte_pdump.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index 3086b2a168..af450695ec 100644 --- a/lib/pdump/rte_pdump.c +++ b/lib/pdump/rte_pdump.c @@ -74,6 +74,7 @@ static const char MZ_RTE_PDUMP_STATS[] = "rte_pdump_stats"; static struct { struct rte_pdump_stats rx[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT]; struct rte_pdump_stats tx[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT]; + const struct rte_memzone *mz; } *pdump_stats; /* Create a clone of mbuf to be placed into ring. */ @@ -429,6 +430,7 @@ rte_pdump_init(void) return -1; } pdump_stats = mz->addr; + pdump_stats->mz = mz; ret = rte_mp_action_register(PDUMP_MP, pdump_server); if (ret && rte_errno != ENOTSUP) @@ -441,6 +443,11 @@ rte_pdump_uninit(void) { rte_mp_action_unregister(PDUMP_MP); + if (pdump_stats != NULL) { + rte_memzone_free(pdump_stats->mz); + pdump_stats = NULL; + } + return 0; }