d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

usertools: replace unsafe input function

Browse Source 
LGTM static code analysis tool reports that the function 'input' is
unsafe. Changed to use raw_input which then converts it using
ast.literal_eval() which is safe.

Fixes: d1b94da4a4 ("usertools: add client script for telemetry")
Cc: stable@dpdk.org

Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
This commit is contained in:
Andrius Sirvys 2019-04-08 14:54:41 +01:00 committed by Thomas Monjalon
parent 2804529fe0
commit 53f293c9a7
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
usertools/dpdk-telemetry-client.py
View File

@ -15,6 +15,11 @@
GLOBAL_METRICS_REQ = "{\"action\":0,\"command\":\"global_stat_values\",\"data\":null}"
DEFAULT_FP = "/var/run/dpdk/default_client"
try:
raw_input # Python 2
except NameError:
raw_input = input # Python 3
class Socket:
def __init__(self):
@ -73,7 +78,7 @@ def requestMetrics(self): # Requests metrics for given client
def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
print("\nPlease enter the number of times you'd like to continuously request Metrics:")
n_requests = int(input("\n:"))
n_requests = int(ast.literal_eval(raw_input("\n:")))
print("\033[F") #Removes the user input from screen, cleans it up
print("\033[K")
for i in range(n_requests):
@ -94,7 +99,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
print("[4] Unregister client")
try:
self.choice = int(input("\n:"))
self.choice = int(ast.literal_eval(raw_input("\n:")))
print("\033[F") #Removes the user input for screen, cleans it up
print("\033[K")
if self.choice == 1: