From 5583abf6a3ef1c692e703e3080b750e583a89e8b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 9 Nov 2022 15:46:49 -0800 Subject: [PATCH] examples: remove unnecessary null checks The function rte_free() already handles NULL argument; therefore the checks in this code are unnecessary. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 3 +-- examples/fips_validation/main.c | 15 +++++---------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index e767973ed8..21304d6618 100644 --- a/examples/distributor/main.c +++ b/examples/distributor/main.c @@ -1017,8 +1017,7 @@ main(int argc, char *argv[]) print_stats(); - if (pd) - rte_free(pd); + rte_free(pd); rte_free(pr); /* clean up the EAL */ diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 9a9babb53a..622f8b5a6e 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -963,8 +963,7 @@ prepare_rsa_op(void) asym->rsa.message.data = msg.val; asym->rsa.message.length = msg.len; - if (vec.rsa.signature.val) - rte_free(vec.rsa.signature.val); + rte_free(vec.rsa.signature.val); vec.rsa.signature.val = rte_zmalloc(NULL, vec.rsa.n.len, 0); vec.rsa.signature.len = vec.rsa.n.len; @@ -1012,11 +1011,9 @@ prepare_ecdsa_op(void) asym->ecdsa.k.data = vec.ecdsa.k.val; asym->ecdsa.k.length = vec.ecdsa.k.len; - if (vec.ecdsa.r.val) - rte_free(vec.ecdsa.r.val); + rte_free(vec.ecdsa.r.val); - if (vec.ecdsa.s.val) - rte_free(vec.ecdsa.s.val); + rte_free(vec.ecdsa.s.val); vec.ecdsa.r.len = info.interim_info.ecdsa_data.curve_len; vec.ecdsa.r.val = rte_zmalloc(NULL, vec.ecdsa.r.len, 0); @@ -1061,11 +1058,9 @@ prepare_ecfpm_op(void) asym->ecpm.scalar.data = vec.ecdsa.pkey.val; asym->ecpm.scalar.length = vec.ecdsa.pkey.len; - if (vec.ecdsa.qx.val) - rte_free(vec.ecdsa.qx.val); + rte_free(vec.ecdsa.qx.val); - if (vec.ecdsa.qy.val) - rte_free(vec.ecdsa.qy.val); + rte_free(vec.ecdsa.qy.val); vec.ecdsa.qx.len = info.interim_info.ecdsa_data.curve_len; vec.ecdsa.qx.val = rte_zmalloc(NULL, vec.ecdsa.qx.len, 0);