d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/crypto-perf: fix null dereference

Browse Source 
Dereferencing a pointer that might be null key_token when calling strstr.
Check if the pointer is null before.

Coverity issue: 141071
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
This commit is contained in:
Slawomir Mrozowicz 2017-02-10 15:22:30 +01:00 committed by Pablo de Lara
parent 7fb95c3602
commit 559ef9201a
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/test-crypto-perf/cperf_test_vector_parsing.c
View File

@ -237,15 +237,19 @@ parse_entry(char *entry, struct cperf_test_vector *vector,
uint8_t *data = NULL;
char *token, *key_token;
if (entry == NULL) {
printf("Expected entry value\n");
return -1;
}
/* get key */
token = strtok(entry, CPERF_ENTRY_DELIMITER);
key_token = token;
/* get values for key */
token = strtok(NULL, CPERF_ENTRY_DELIMITER);
if (token == NULL) {
printf("Expected 'key = values' but was '%.40s'..\n",
key_token);
if (key_token == NULL || token == NULL) {
printf("Expected 'key = values' but was '%.40s'..\n", entry);
return -1;
}