d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/mlx5: fix shared Rx queue segment configuration match

Browse Source 
While joining the shared Rx queue to the existing queue group,
the queue configurations is checked to be the same as it was
specified in the first group queue creation - all shared
queues should be created with identical configurations.

During the Rx queue creation the buffer split segment
configuration can be altered - the zero segment sizes are
substituted with the actual ones, inherited from the pools,
number of segments can be extended to cover the maximal
packet length, etc. It means the actual queue segment
configuration can not be used directly to match the
configuration provided in the queue setup call.

To resolve an issue we should store original parameters
in the shared queue structure and perform the check against
one of these stored ones.

Fixes: 09c2555303 ("net/mlx5: support shared Rx queue")

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
This commit is contained in:
Viacheslav Ovsiienko 2021-11-24 16:33:16 +02:00 committed by Raslan Darawsheh
parent 94421842de
commit 572c9d4bda
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/mlx5/mlx5_rx.h
View File

@ -164,6 +164,9 @@ struct mlx5_rxq_ctrl {
uint32_t flow_mark_n; /* Number of Mark/Flag flows using this Queue. */ uint32_t flow_mark_n; /* Number of Mark/Flag flows using this Queue. */
uint32_t flow_tunnels_n[MLX5_FLOW_TUNNEL]; /* Tunnels counters. */ uint32_t flow_tunnels_n[MLX5_FLOW_TUNNEL]; /* Tunnels counters. */
uint32_t wqn; /* WQ number. */ uint32_t wqn; /* WQ number. */
uint32_t rxseg_n; /* Number of split segment descriptions. */
struct rte_eth_rxseg_split rxseg[MLX5_MAX_RXQ_NSEG];
/* Saved original buffer split segment configuration. */
uint16_t dump_file_n; /* Number of dump files. */ uint16_t dump_file_n; /* Number of dump files. */
}; };

18
drivers/net/mlx5/mlx5_rxq.c
View File

@ -775,11 +775,14 @@ mlx5_shared_rxq_match(struct mlx5_rxq_ctrl *rxq_ctrl, struct rte_eth_dev *dev,
dev->data->port_id, idx); dev->data->port_id, idx);
return false; return false;
} else if (mp == NULL) { } else if (mp == NULL) {
if (conf->rx_nseg != rxq_ctrl->rxseg_n) {
DRV_LOG(ERR, "port %u queue index %u failed to join shared group: segment number mismatch",
dev->data->port_id, idx);
return false;
}
for (i = 0; i < conf->rx_nseg; i++) { for (i = 0; i < conf->rx_nseg; i++) {
if (conf->rx_seg[i].split.mp != if (memcmp(&conf->rx_seg[i].split, &rxq_ctrl->rxseg[i],
rxq_ctrl->rxq.rxseg[i].mp || sizeof(struct rte_eth_rxseg_split))) {
conf->rx_seg[i].split.length !=
rxq_ctrl->rxq.rxseg[i].length) {
DRV_LOG(ERR, "port %u queue index %u failed to join shared group: segment %u configuration mismatch", DRV_LOG(ERR, "port %u queue index %u failed to join shared group: segment %u configuration mismatch",
dev->data->port_id, idx, i); dev->data->port_id, idx, i);
return false; return false;
@ -1602,6 +1605,13 @@ mlx5_rxq_new(struct rte_eth_dev *dev, struct mlx5_rxq_priv *rxq,
rxq->ctrl = tmpl; rxq->ctrl = tmpl;
LIST_INSERT_HEAD(&tmpl->owners, rxq, owner_entry); LIST_INSERT_HEAD(&tmpl->owners, rxq, owner_entry);
MLX5_ASSERT(n_seg && n_seg <= MLX5_MAX_RXQ_NSEG); MLX5_ASSERT(n_seg && n_seg <= MLX5_MAX_RXQ_NSEG);
/*
* Save the original segment configuration in the shared queue
* descriptor for the later check on the sibling queue creation.
*/
tmpl->rxseg_n = n_seg;
rte_memcpy(tmpl->rxseg, qs_seg,
sizeof(struct rte_eth_rxseg_split) * n_seg);
/* /*
* Build the array of actual buffer offsets and lengths. * Build the array of actual buffer offsets and lengths.
* Pad with the buffers from the last memory pool if * Pad with the buffers from the last memory pool if