d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

event/opdl: replace sprintf with snprintf

Browse Source 
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.

Fixes: 3c7f3dcfb0 ("event/opdl: add PMD main body and helper function")
Cc: stable@dpdk.org

Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
This commit is contained in:
Pallantla Poornima 2019-02-04 07:18:02 +00:00 committed by Jerin Jacob
parent c13b1ad719
commit 57362ddf42
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/event/opdl/opdl_evdev.c
View File

@ -422,16 +422,17 @@ opdl_dump(struct rte_eventdev *dev, FILE *f)
else else
p_type = "????"; p_type = "????";
sprintf(queue_id, "%02u", port->external_qid); snprintf(queue_id, sizeof(queue_id), "%02u",
port->external_qid);
if (port->p_type == OPDL_REGULAR_PORT || if (port->p_type == OPDL_REGULAR_PORT ||
port->p_type == OPDL_ASYNC_PORT) port->p_type == OPDL_ASYNC_PORT)
sprintf(total_cyc, snprintf(total_cyc, sizeof(total_cyc),
" %'16"PRIu64"", " %'16"PRIu64"",
(cpg != 0 ? (cpg != 0 ?
port->port_stat[total_cycles] / cpg port->port_stat[total_cycles] / cpg
: 0)); : 0));
else else
sprintf(total_cyc, snprintf(total_cyc, sizeof(total_cyc),
" ----"); " ----");
fprintf(f, fprintf(f,
"%4s %10u %8u %9s %'16"PRIu64" %'16"PRIu64" %s " "%4s %10u %8u %9s %'16"PRIu64" %'16"PRIu64" %s "

7
drivers/event/opdl/opdl_evdev_xstats.c
View File

@ -32,10 +32,9 @@ opdl_xstats_init(struct rte_eventdev *dev)
uint32_t index = (i * max_num_port_xstat) + j; uint32_t index = (i * max_num_port_xstat) + j;
/* Name */ /* Name */
sprintf(device->port_xstat[index].stat.name, snprintf(device->port_xstat[index].stat.name,
"port_%02u_%s", sizeof(device->port_xstat[index].stat.name),
i, "port_%02u_%s", i, port_xstat_str[j]);
port_xstat_str[j]);
/* ID */ /* ID */
device->port_xstat[index].id = index; device->port_xstat[index].id = index;