d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test: fix buffer overflow in Tx burst

Browse Source 
The Tx buffer may overflow when there is more than one port.

Fixes: 002ade70e9 ("app/test: measure cycles per packet in Rx/Tx")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
Acked-by: Jeff Guo <jia.guo@intel.com>
Tested-by: Wei Ling <weix.ling@intel.com>
This commit is contained in:
Alvin Zhang 2020-11-25 17:46:22 +08:00 committed by Thomas Monjalon
parent dc8ac7980c
commit 58325f094a
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/test/test_pmd_perf.c
View File

@ -606,10 +606,10 @@ poll_burst(void *args)
static int
exec_burst(uint32_t flags, int lcore)
{
unsigned i, portid, nb_tx = 0;
unsigned int portid, nb_tx = 0;
struct lcore_conf *conf;
uint32_t pkt_per_port;
int num, idx = 0;
int num, i, idx = 0;
int diff_tsc;
conf = &lcore_conf[lcore];
@ -628,16 +628,14 @@ exec_burst(uint32_t flags, int lcore)
rte_atomic64_set(&start, 1);
/* start xmit */
i = 0;
while (num) {
nb_tx = RTE_MIN(MAX_PKT_BURST, num);
for (i = 0; i < conf->nb_ports; i++) {
portid = conf->portlist[i];
nb_tx = rte_eth_tx_burst(portid, 0,
&tx_burst[idx], nb_tx);
idx += nb_tx;
num -= nb_tx;
}
portid = conf->portlist[i];
nb_tx = rte_eth_tx_burst(portid, 0, &tx_burst[idx], nb_tx);
idx += nb_tx;
num -= nb_tx;
i = (i >= conf->nb_ports - 1) ? 0 : (i + 1);
}
sleep(5);