d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

raw/ntb: check SPAD user index

Browse Source 
This patch adds checking spad user index validity when set or get attr.

Fixes: 277310027965 ("raw/ntb: introduce NTB raw device driver")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
This commit is contained in:
Chengwen Feng 2021-04-21 10:08:15 +08:00 committed by Thomas Monjalon
parent 11e027022d
commit 586f12881d
1 changed files with 8 additions and 0 deletions

8
drivers/raw/ntb/ntb.c

@ -1080,6 +1080,10 @@ ntb_attr_set(struct rte_rawdev *dev, const char *attr_name,
if (hw->ntb_ops->spad_write == NULL) if (hw->ntb_ops->spad_write == NULL)
return -ENOTSUP; return -ENOTSUP;
index = atoi(&attr_name[NTB_SPAD_USER_LEN]); index = atoi(&attr_name[NTB_SPAD_USER_LEN]);
if (index < 0 || index >= NTB_SPAD_USER_MAX_NUM) {
NTB_LOG(ERR, "Invalid attribute (%s)", attr_name);
return -EINVAL;
}
(*hw->ntb_ops->spad_write)(dev, hw->spad_user_list[index], (*hw->ntb_ops->spad_write)(dev, hw->spad_user_list[index],
1, attr_value); 1, attr_value);
NTB_LOG(DEBUG, "Set attribute (%s) Value (%" PRIu64 ")", NTB_LOG(DEBUG, "Set attribute (%s) Value (%" PRIu64 ")",
@ -1174,6 +1178,10 @@ ntb_attr_get(struct rte_rawdev *dev, const char *attr_name,
if (hw->ntb_ops->spad_read == NULL) if (hw->ntb_ops->spad_read == NULL)
return -ENOTSUP; return -ENOTSUP;
index = atoi(&attr_name[NTB_SPAD_USER_LEN]); index = atoi(&attr_name[NTB_SPAD_USER_LEN]);
if (index < 0 || index >= NTB_SPAD_USER_MAX_NUM) {
NTB_LOG(ERR, "Attribute (%s) out of range", attr_name);
return -EINVAL;
}
*attr_value = (*hw->ntb_ops->spad_read)(dev, *attr_value = (*hw->ntb_ops->spad_read)(dev,
hw->spad_user_list[index], 0); hw->spad_user_list[index], 0);
NTB_LOG(DEBUG, "Attribute (%s) Value (%" PRIu64 ")", NTB_LOG(DEBUG, "Attribute (%s) Value (%" PRIu64 ")",