d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/enic: enable limited passthru flow action

Browse Source 
Some apps like VPP use PASSTHRU+MARK flow rules to offload packet
matching to the NIC. Just like MARK+RSS used by OVS-DPDK and others,
PASSTHRU+MARK is used to "mark and then receive normally". Recent VIC
adapters support such flow rules, so enable PASSTHRU for this limited
use case.

Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
This commit is contained in:
Hyong Youb Kim 2019-03-02 02:42:45 -08:00 committed by Ferruh Yigit
parent e9434f6f60
commit 5af7af4d6b
3 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/guides/nics/enic.rst
View File

@ -256,7 +256,7 @@ Generic Flow API is supported. The baseline support is:
- Attributes: ingress
- Items: eth, ipv4, ipv6, udp, tcp, vxlan, inner eth, ipv4, ipv6, udp, tcp
- Actions: queue, mark, drop, flag, rss, and void
- Actions: queue, mark, drop, flag, rss, passthru, and void
- Selectors: 'is', 'spec' and 'mask'. 'last' is not supported
- In total, up to 64 bytes of mask is allowed across all headers
@ -451,6 +451,10 @@ PKT_RX_VLAN_STRIPPED mbuf flags would not be set. This mode is enabled with the
were added. Since there currently is no grouping or priority support,
'catch-all' filters should be added last.
- The supported range of IDs for the 'MARK' action is 0 - 0xFFFD.
- RSS and PASSTHRU actions only support "receive normally". They are limited
to supporting MARK + RSS and PASSTHRU + MARK to allow the application to mark
packets and then receive them normally. These require 1400 series VIC adapters
and latest firmware.
- **Statistics**

1
doc/guides/rel_notes/release_19_05.rst
View File

@ -80,6 +80,7 @@ New Features
* **Updated the enic driver.**
* Added limited support for RSS.
* Added limited support for PASSTHRU.
Removed Items

20
drivers/net/enic/enic_flow.c
View File

@ -283,6 +283,7 @@ static const enum rte_flow_action_type enic_supported_actions_v2_id[] = {
RTE_FLOW_ACTION_TYPE_MARK,
RTE_FLOW_ACTION_TYPE_FLAG,
RTE_FLOW_ACTION_TYPE_RSS,
RTE_FLOW_ACTION_TYPE_PASSTHRU,
RTE_FLOW_ACTION_TYPE_END,
};
@ -292,6 +293,7 @@ static const enum rte_flow_action_type enic_supported_actions_v2_drop[] = {
RTE_FLOW_ACTION_TYPE_FLAG,
RTE_FLOW_ACTION_TYPE_DROP,
RTE_FLOW_ACTION_TYPE_RSS,
RTE_FLOW_ACTION_TYPE_PASSTHRU,
RTE_FLOW_ACTION_TYPE_END,
};
@ -302,6 +304,7 @@ static const enum rte_flow_action_type enic_supported_actions_v2_count[] = {
RTE_FLOW_ACTION_TYPE_DROP,
RTE_FLOW_ACTION_TYPE_COUNT,
RTE_FLOW_ACTION_TYPE_RSS,
RTE_FLOW_ACTION_TYPE_PASSTHRU,
RTE_FLOW_ACTION_TYPE_END,
};
@ -1072,6 +1075,7 @@ enic_copy_action_v2(struct enic *enic,
{
enum { FATE = 1, MARK = 2, };
uint32_t overlap = 0;
bool passthru = false;
FLOW_TRACE();
@ -1164,6 +1168,19 @@ enic_copy_action_v2(struct enic *enic,
overlap |= FATE;
break;
}
case RTE_FLOW_ACTION_TYPE_PASSTHRU: {
/*
* Like RSS above, PASSTHRU + MARK may be used to
* "mark and then receive normally". MARK usually comes
* after PASSTHRU, so remember we have seen passthru
* and check for mark later.
*/
if (overlap & FATE)
return ENOTSUP;
overlap |= FATE;
passthru = true;
break;
}
case RTE_FLOW_ACTION_TYPE_VOID:
continue;
default:
@ -1171,6 +1188,9 @@ enic_copy_action_v2(struct enic *enic,
break;
}
}
/* Only PASSTHRU + MARK is allowed */
if (passthru && !(overlap & MARK))
return ENOTSUP;
if (!(overlap & FATE))
return ENOTSUP;
enic_action->type = FILTER_ACTION_V2;