d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test/crypto: remove QAT specific check

Browse Source 
In test_queue_pair_descriptor_setup() and
test_device_configure_invalid_queue_pair_ids a QAT specific
check is there, however the test case can be run on any PMD.
Hence removed the unnecessary check.

test_queue_pair_descriptor_setup and
test_device_configure_invalid_queue_pair_ids execution
need to be altered as the valid device values should be
configured in the end so that all other tests can be
executed.

Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
This commit is contained in:
Akhil Goyal 2020-05-10 04:42:16 +05:30
parent 33c9e904fb
commit 5bf52c656e
1 changed files with 6 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
app/test/test_cryptodev.c
View File

@ -767,27 +767,19 @@ test_device_configure_invalid_queue_pair_ids(void)
struct crypto_testsuite_params *ts_params = &testsuite_params; struct crypto_testsuite_params *ts_params = &testsuite_params;
uint16_t orig_nb_qps = ts_params->conf.nb_queue_pairs; uint16_t orig_nb_qps = ts_params->conf.nb_queue_pairs;
/* This test is for QAT and NITROX PMDs only */
if (gbl_driver_id != rte_cryptodev_driver_id_get(
RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)) &&
gbl_driver_id != rte_cryptodev_driver_id_get(
RTE_STR(CRYPTODEV_NAME_NITROX_PMD)))
return -ENOTSUP;
/* Stop the device in case it's started so it can be configured */ /* Stop the device in case it's started so it can be configured */
rte_cryptodev_stop(ts_params->valid_devs[0]); rte_cryptodev_stop(ts_params->valid_devs[0]);
/* valid - one queue pairs */ /* valid - max value queue pairs */
ts_params->conf.nb_queue_pairs = 1; ts_params->conf.nb_queue_pairs = orig_nb_qps;
TEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0], TEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0],
&ts_params->conf), &ts_params->conf),
"Failed to configure cryptodev: dev_id %u, qp_id %u", "Failed to configure cryptodev: dev_id %u, qp_id %u",
ts_params->valid_devs[0], ts_params->conf.nb_queue_pairs); ts_params->valid_devs[0], ts_params->conf.nb_queue_pairs);
/* valid - one queue pairs */
/* valid - max value queue pairs */ ts_params->conf.nb_queue_pairs = 1;
ts_params->conf.nb_queue_pairs = orig_nb_qps;
TEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0], TEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0],
&ts_params->conf), &ts_params->conf),
@ -845,15 +837,9 @@ test_queue_pair_descriptor_setup(void)
uint16_t qp_id; uint16_t qp_id;
/* This test is for QAT PMD only */
if (gbl_driver_id != rte_cryptodev_driver_id_get(
RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)))
return -ENOTSUP;
/* Stop the device in case it's started so it can be configured */ /* Stop the device in case it's started so it can be configured */
rte_cryptodev_stop(ts_params->valid_devs[0]); rte_cryptodev_stop(ts_params->valid_devs[0]);
rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
TEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0], TEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0],
@ -11799,10 +11785,10 @@ static struct unit_test_suite cryptodev_testsuite = {
.unit_test_cases = { .unit_test_cases = {
TEST_CASE_ST(ut_setup, ut_teardown, TEST_CASE_ST(ut_setup, ut_teardown,
test_device_configure_invalid_dev_id), test_device_configure_invalid_dev_id),
TEST_CASE_ST(ut_setup, ut_teardown,
test_device_configure_invalid_queue_pair_ids),
TEST_CASE_ST(ut_setup, ut_teardown, TEST_CASE_ST(ut_setup, ut_teardown,
test_queue_pair_descriptor_setup), test_queue_pair_descriptor_setup),
TEST_CASE_ST(ut_setup, ut_teardown,
test_device_configure_invalid_queue_pair_ids),
TEST_CASE_ST(ut_setup, ut_teardown, TEST_CASE_ST(ut_setup, ut_teardown,
test_multi_session), test_multi_session),