d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: guarantee port array access in range

Browse Source 
Coverity complains about out of bound access, which is a false positive.

The return value of the 'parse_port_list()' can't be bigger than
'maxsize' because of the logic in the function. ('value >= (int)maxsize'
check and 'marked[]' usage.)

But this is not explicitly clear, causing coverity warning and same
question can be rise by reviews later.

Adding a redundant check to highlight the access is in range, this is
done by replacing existing redundant check.

This is also good to protect against out out bound access in case
'parse_port_list()' behaviour changes later unexpectedly.

Coverity issue: 354229
Fixes: 2df00d562d ("app/testpmd: add --portlist option")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
This commit is contained in:
Ferruh Yigit 2020-02-19 12:40:03 +00:00
parent 5693233823
commit 5e4154cec4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/test-pmd/config.c
View File

@ -2703,7 +2703,7 @@ parse_fwd_portlist(const char *portlist)
* and thereby calculate the total number of
* valid ports
*/
for (i = 0; i < portcount && valid_port_count < portcount; i++) {
for (i = 0; i < portcount && i < RTE_DIM(portindex); i++) {
if (rte_eth_dev_is_valid_port(portindex[i])) {
portindex[valid_port_count] = portindex[i];
valid_port_count++;