d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/mlx5: fix device stop with multiple regions

Browse Source 
LIST macro are not safe when inside a LIST_FOREACH() a LIST_REMOVE() is
called to remove an entry, this behavior is undefined causing some entries
to disappear from the list.

Fixes: 6e78005a9b30 ("net/mlx5: add reference counter on DPDK Tx queues")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
This commit is contained in:
Nélio Laranjeiro 2017-10-25 16:04:36 +02:00 committed by Ferruh Yigit
parent 3ba62841c2
commit 5f64e6bfa1
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/mlx5/mlx5_trigger.c
View File

@ -188,7 +188,7 @@ mlx5_dev_start(struct rte_eth_dev *dev)
error:
/* Rollback. */
dev->data->dev_started = 0;
LIST_FOREACH(mr, &priv->mr, next)
for (mr = LIST_FIRST(&priv->mr); mr; mr = LIST_FIRST(&priv->mr))
priv_mr_release(priv, mr);
priv_flow_stop(priv, &priv->flows);
priv_dev_traffic_disable(priv, dev);
@ -230,9 +230,8 @@ mlx5_dev_stop(struct rte_eth_dev *dev)
priv_dev_interrupt_handler_uninstall(priv, dev);
priv_txq_stop(priv);
priv_rxq_stop(priv);
LIST_FOREACH(mr, &priv->mr, next) {
for (mr = LIST_FIRST(&priv->mr); mr; mr = LIST_FIRST(&priv->mr))
priv_mr_release(priv, mr);
}
priv_flow_delete_drop_queue(priv);
priv_unlock(priv);
}