From 5fe5678de9c508332ea37d90a8267c3a2066219e Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Wed, 14 Nov 2018 11:58:59 +0000 Subject: [PATCH] app/testpmd: fix memory leak for DSCP table Fix memory leak for dscp table reported by coverity Coverity issue: 326961 Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") Cc: stable@dpdk.org Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline_mtr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index 846de88db5..c506d87ee5 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -1148,15 +1148,15 @@ static void cmd_set_port_meter_dscp_table_parsed(void *parsed_result, } if (port_id_is_invalid(port_id, ENABLED_WARN)) - return; + goto free_table; /* Update Meter DSCP Table*/ ret = rte_mtr_meter_dscp_table_update(port_id, mtr_id, dscp_table, &error); - if (ret != 0) { + if (ret != 0) print_err_msg(&error); - return; - } + +free_table: free(dscp_table); }