From 66f624e4eaf30638878d51c445e4c21ade33d466 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 10 Oct 2022 11:44:47 +0100 Subject: [PATCH] kni: add deprecation warning at runtime When KNI is being used at runtime, output a warning message about its deprecated status. This is part of the deprecation process for KNI agreed by the DPDK technical board.[1] [1] https://mails.dpdk.org/archives/dev/2022-June/243596.html Signed-off-by: Bruce Richardson Reviewed-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 6 ++---- lib/kni/rte_kni.c | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 0f29d76093..05cacb3ea8 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -37,10 +37,8 @@ Deprecation Notices applications - other technologies such as virtio-user are recommended instead. Following the DPDK technical board `decision `_ - and `refinement `_: - - * Some deprecation warnings will be added in DPDK 22.11. - * The KNI kernel module, library and PMD will be removed from the DPDK 23.11. + and `refinement `_, + the KNI kernel module, library and PMD will be removed from the DPDK 23.11 release. * lib: will fix extending some enum/define breaking the ABI. There are multiple samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c index 3737a91de7..8ab6c47153 100644 --- a/lib/kni/rte_kni.c +++ b/lib/kni/rte_kni.c @@ -96,6 +96,8 @@ static volatile int kni_fd = -1; int rte_kni_init(unsigned int max_kni_ifaces __rte_unused) { + RTE_LOG(WARNING, KNI, "WARNING: KNI is deprecated and will be removed in DPDK 23.11\n"); + #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 10, 0) if (rte_eal_iova_mode() != RTE_IOVA_PA) { RTE_LOG(ERR, KNI, "KNI requires IOVA as PA\n");