From 6793a1f771556c2d28122171e147094cba8fefc4 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Fri, 20 Jul 2018 13:34:52 +0200 Subject: [PATCH] devtools: fix checkpatch for filename with space If the patch filename or the temporary file path have a space in their name, the script checkpatches.sh does not work. The variables for the filenames must be enclosed in quotes in order to preserve spaces. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Signed-off-by: Thomas Monjalon Acked-by: Neil Horman --- devtools/checkpatches.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 1439bce94f..e97a4f2c96 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -25,7 +25,7 @@ NEW_TYPEDEFS,COMPARISON_TO_NULL" clean_tmp_files() { if echo $tmpinput | grep -q '^checkpatches\.' ; then - rm -f $tmpinput + rm -f "$tmpinput" fi } @@ -77,13 +77,13 @@ check () { # elif [ -n "$2" ] ; then tmpinput=$(mktemp checkpatches.XXXXXX) git format-patch --find-renames \ - --no-stat --stdout -1 $commit > $tmpinput + --no-stat --stdout -1 $commit > "$tmpinput" else tmpinput=$(mktemp checkpatches.XXXXXX) - cat > $tmpinput + cat > "$tmpinput" fi - report=$($DPDK_CHECKPATCH_PATH $options $tmpinput 2>/dev/null) + report=$($DPDK_CHECKPATCH_PATH $options "$tmpinput" 2>/dev/null) if [ $? -ne 0 ] ; then $verbose || printf '\n### %s\n\n' "$3" printf '%s\n' "$report" | sed -n '1,/^total:.*lines checked$/p'