eal: return error when option register fails

Make rte_option_register return a negative value when
an error occur.

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
This commit is contained in:
Gaetan Rivet 2018-12-20 18:06:47 +01:00 committed by Thomas Monjalon
parent e48839afff
commit 68c4768d36
2 changed files with 10 additions and 4 deletions

View File

@ -57,8 +57,12 @@ struct rte_option {
*
* @param opt
* Structure describing the option to parse.
*
* @return
* 0 on success, <0 otherwise.
*/
void __rte_experimental
__rte_experimental
int
rte_option_register(struct rte_option *opt);
#ifdef __cplusplus

View File

@ -38,7 +38,8 @@ rte_option_parse(const char *opt)
return -1;
}
void __rte_experimental
__rte_experimental
int
rte_option_register(struct rte_option *opt)
{
struct rte_option *option;
@ -49,7 +50,7 @@ rte_option_register(struct rte_option *opt)
if (strcmp(gopt->name, opt->name) == 0) {
RTE_LOG(ERR, EAL, "Option %s is already a common EAL option.\n",
opt->name);
return;
return -1;
}
gopt++;
}
@ -58,11 +59,12 @@ rte_option_register(struct rte_option *opt)
if (strcmp(opt->name, option->name) == 0) {
RTE_LOG(ERR, EAL, "Option %s has already been registered.\n",
opt->name);
return;
return -1;
}
}
TAILQ_INSERT_HEAD(&rte_option_list, opt, next);
return 0;
}
void