d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

config: remove explicit undef of unset values

Browse Source 
Rather than explicitly clearing any setting of undefined values in our
rte_config.h file, it's better to instead just add a comment that the
value is not set. Using a comment allows the user to set the value using
CFLAGS or similar mechanism without the config file clearing the value
again.

The text used "<VALUE> is not set" is modelled after the kernel approach
of doing the same thing.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
This commit is contained in:
Bruce Richardson 2021-12-16 11:14:30 +00:00 committed by David Marchand
parent e3fd286ec4
commit 68fc7c39ee
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
config/rte_config.h
View File

@ -83,13 +83,13 @@
/* ip_fragmentation defines */
#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8
#undef RTE_LIBRTE_IP_FRAG_TBL_STAT
// RTE_LIBRTE_IP_FRAG_TBL_STAT is not set
/* rte_power defines */
#define RTE_MAX_LCORE_FREQS 64
/* rte_sched defines */
#undef RTE_SCHED_CMAN
// RTE_SCHED_CMAN is not set
/* rte_graph defines */
#define RTE_GRAPH_BURST_SIZE 256
@ -120,7 +120,7 @@
/* i40e defines */
#define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1
#undef RTE_LIBRTE_I40E_16BYTE_RX_DESC
// RTE_LIBRTE_I40E_16BYTE_RX_DESC is not set
#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64
#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4
#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4
@ -133,6 +133,6 @@
#define RTE_LIBRTE_QEDE_FW ""
/* DLB2 defines */
#undef RTE_LIBRTE_PMD_DLB2_QUELL_STATS
// RTE_LIBRTE_PMD_DLB2_QUELL_STATS is not set
#endif /* _RTE_CONFIG_H_ */

8
devtools/checkpatches.sh
View File

@ -158,6 +158,14 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
# '// XXX is not set' must be preferred over '#undef XXX'
awk -v FOLDERS='config/rte_config.h' \
-v EXPRESSIONS='#undef' \
-v RET_ON_FAIL=1 \
-v MESSAGE='Using "#undef XXX", prefer "// XXX is not set"' \
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
return $res
}