d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/sfc/base: fix warnings from VS2015 C compiler (C4100)

Browse Source 
Fix multiple level 4 warnings
"C4100: 'xxx': unreferenced formal parameter"
no functional changes.

The _NOTE(ARGUNUSED(xxx)) annotations are being exposed to the Visual
Studio 2015 C compiler with the following:

    #define _NOTE_ARGUNUSED(...) UNREFERENCED_PARAMETER((__VA_ARGS__));
    #define _NOTE(_annotation)   _NOTE_ ## _annotation

Fixes: 099c33bef3 ("net/sfc/base: import MCDI proxy authorization")
Fixes: e7cd430c86 ("net/sfc/base: import SFN7xxx family support")
Fixes: 7243cc0869 ("net/sfc/base: import software per-queue statistics")
Fixes: d96a34d165 ("net/sfc/base: import NVRAM support")
Fixes: 05fce2ce84 ("net/sfc/base: import libefx licensing")
Cc: stable@dpdk.org

Signed-off-by: Andrew Lee <alee@solarflare.com>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
This commit is contained in:
Andrew Lee 2017-11-16 08:04:34 +00:00 committed by Ferruh Yigit
parent 0b2755fc10
commit 698c68d6f2
6 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/sfc/base/ef10_nvram.c
View File

@ -672,6 +672,7 @@ ef10_nvram_buffer_validate(
int pos;
efx_rc_t rc;
_NOTE(ARGUNUSED(enp, partn))
EFX_STATIC_ASSERT(sizeof (*header) <= EF10_NVRAM_CHUNK);
if ((partn_data == NULL) || (partn_size == 0)) {
@ -1282,6 +1283,8 @@ ef10_nvram_buf_read_tlv(
caddr_t value;
efx_rc_t rc;
_NOTE(ARGUNUSED(enp))
if ((seg_data == NULL) || (max_seg_size == 0)) {
rc = EINVAL;
goto fail1;

2
drivers/net/sfc/base/ef10_rx.c
View File

@ -749,6 +749,8 @@ ef10_rx_qpost(
unsigned int offset;
unsigned int id;
_NOTE(ARGUNUSED(completed))
#if EFSYS_OPT_RX_PACKED_STREAM
/*
* Real size of the buffer does not fit into ESF_DZ_RX_KER_BYTE_CNT

8
drivers/net/sfc/base/ef10_tx.c
View File

@ -606,6 +606,8 @@ ef10_tx_qdesc_dma_create(
__in boolean_t eop,
__out efx_desc_t *edp)
{
_NOTE(ARGUNUSED(etp))
/* No limitations on boundary crossing */
EFSYS_ASSERT(size <= etp->et_enp->en_nic_cfg.enc_tx_dma_desc_size_max);
@ -629,6 +631,8 @@ ef10_tx_qdesc_tso_create(
__in uint8_t tcp_flags,
__out efx_desc_t *edp)
{
_NOTE(ARGUNUSED(etp))
EFSYS_PROBE4(tx_desc_tso_create, unsigned int, etp->et_index,
uint16_t, ipv4_id, uint32_t, tcp_seq,
uint8_t, tcp_flags);
@ -651,6 +655,8 @@ ef10_tx_qdesc_tso2_create(
__out_ecount(count) efx_desc_t *edp,
__in int count)
{
_NOTE(ARGUNUSED(etp, count))
EFSYS_PROBE4(tx_desc_tso2_create, unsigned int, etp->et_index,
uint16_t, ipv4_id, uint32_t, tcp_seq,
uint16_t, tcp_mss);
@ -680,6 +686,8 @@ ef10_tx_qdesc_vlantci_create(
__in uint16_t tci,
__out efx_desc_t *edp)
{
_NOTE(ARGUNUSED(etp))
EFSYS_PROBE2(tx_desc_vlantci_create, unsigned int, etp->et_index,
uint16_t, tci);

2
drivers/net/sfc/base/efx_ev.c
View File

@ -1417,6 +1417,8 @@ efx_ev_qstat_name(
__in efx_nic_t *enp,
__in unsigned int id)
{
_NOTE(ARGUNUSED(enp))
EFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);
EFSYS_ASSERT3U(id, <, EV_NQSTATS);

6
drivers/net/sfc/base/efx_lic.c
View File

@ -561,7 +561,7 @@ efx_lic_v1v2_read_key(
{
efx_rc_t rc;
_NOTE(ARGUNUSED(enp))
_NOTE(ARGUNUSED(enp, buffer_size))
EFSYS_ASSERT(length <= (EFX_LICENSE_V1V2_PAYLOAD_LENGTH_MAX +
EFX_LICENSE_V1V2_HEADER_LENGTH));
@ -631,7 +631,7 @@ efx_lic_v1v2_delete_key(
uint32_t move_start = offset + length;
uint32_t move_length = end - move_start;
_NOTE(ARGUNUSED(enp))
_NOTE(ARGUNUSED(enp, buffer_size))
EFSYS_ASSERT(end <= buffer_size);
/* Shift everything after the key down */
@ -649,7 +649,7 @@ efx_lic_v1v2_create_partition(
caddr_t bufferp,
__in size_t buffer_size)
{
_NOTE(ARGUNUSED(enp))
_NOTE(ARGUNUSED(enp, buffer_size))
EFSYS_ASSERT(EFX_LICENSE_V1V2_HEADER_LENGTH <= buffer_size);
/* Write terminator */

2
drivers/net/sfc/base/efx_mcdi.c
View File

@ -809,6 +809,8 @@ efx_mcdi_get_proxy_handle(
{
efx_rc_t rc;
_NOTE(ARGUNUSED(enp))
/*
* Return proxy handle from MCDI request that returned with error
* MC_MCD_ERR_PROXY_PENDING. This handle is used to wait for a matching